Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js

Issue 1437883002: [Background Sync] Align exposed API with spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@remove-periodic
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js b/third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js
index c638025cb8800916662c1dcc2944d54493d0ea22..0df2dca6c08dad07d016d8d5805de99656c531fe 100644
--- a/third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js
+++ b/third_party/WebKit/LayoutTests/http/tests/background_sync/resources/interfaces-worker.js
@@ -6,27 +6,14 @@ test(function() {
assert_idl_attribute(registration, 'sync', 'One-shot SyncManager needs to be exposed on the registration.');
assert_inherits(registration.sync, 'register');
- assert_inherits(registration.sync, 'getRegistration');
- assert_inherits(registration.sync, 'getRegistrations');
- assert_inherits(registration.sync, 'permissionState');
+ assert_inherits(registration.sync, 'getTags');
}, 'SyncManager should be exposed and have the expected interface.');
test(function() {
- assert_own_property(self, 'SyncRegistration', 'SyncRegistration needs to be exposed as a global.');
-
- // FIXME: Assert existence of the attributes when they are properly
- // exposed in the prototype chain. https://crbug.com/43394
- assert_own_property(SyncRegistration.prototype, 'finished');
- assert_own_property(SyncRegistration.prototype, 'unregister');
- assert_own_property(SyncRegistration.prototype, 'tag');
-
-}, 'SyncRegistration should be exposed and have the expected interface.');
-
-test(function() {
assert_own_property(self, 'SyncEvent');
- assert_will_be_idl_attribute(SyncEvent.prototype, 'registration');
+ assert_will_be_idl_attribute(SyncEvent.prototype, 'tag');
// SyncEvent should be extending ExtendableEvent.
assert_inherits(SyncEvent.prototype, 'waitUntil');

Powered by Google App Engine
This is Rietveld 408576698