[Interpreter] Add support for Call bytecode to bytecode graph builder.

src/compiler/bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-graph-builder.h"
 
 #include "src/compiler/linkage.h"
 #include "src/compiler/operator-properties.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 
@@ skipping 534 matching lines @@
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCreateObjectLiteral(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
+Node* BytecodeGraphBuilder::ProcessCallArguments(const Operator* call_op,
+                                                 interpreter::Register callee,
+                                                 interpreter::Register receiver,
+                                                 size_t arity) {
+  Node** all = info()->zone()->NewArray<Node*>(arity);
+  all[0] = environment()->LookupRegister(callee);
+  all[1] = environment()->LookupRegister(receiver);
+  int reciever_index = receiver.index();
+  for (int i = 2; i < arity; ++i) {
+    all[i] = environment()->LookupRegister(
+        interpreter::Register(reciever_index + i - 1));
+  }
+  Node* value = MakeNode(call_op, static_cast<int>(arity), all, false);
+  return value;
+}
+
+
+void BytecodeGraphBuilder::BuildCall(
+    const interpreter::BytecodeArrayIterator& iterator) {
+  // TODO(rmcilroy): Set receiver_hint correctly based on whether the reciever
+  // register has been loaded with null / undefined explicitly or we are sure it
+  // is not null / undefined.
+  ConvertReceiverMode receiver_hint = ConvertReceiverMode::kAny;
+  interpreter::Register callee = iterator.GetRegisterOperand(0);
+  interpreter::Register reciever = iterator.GetRegisterOperand(1);
+  size_t arg_count = iterator.GetCountOperand(2);
+  VectorSlotPair feedback = CreateVectorSlotPair(iterator.GetIndexOperand(3));
+
+  const Operator* call = javascript()->CallFunction(
+      arg_count + 2, language_mode(), feedback, receiver_hint);
+  Node* value = ProcessCallArguments(call, callee, reciever, arg_count + 2);
+  AddEmptyFrameStateInputs(value);

[mythria, 2015/11/12 09:18:36]

Just a note: I moved TODO to add real frame states from AddEmptyFrameStateInputs
to the place where it is called from (BuildNamedLoad and BuildBinaryOp). Since
the function says AddEmptyFrameState, I felt we should not have a TODO on the
function but have it from the place where it is called from. Now, I feel it is
better to add it to the function declaration to avoid having a TODO at every
place it is called from. 

[rmcilroy, 2015/11/12 12:28:03]

SGTM, done.

+  environment()->BindAccumulator(value);
+}
+
+
 void BytecodeGraphBuilder::VisitCall(
     const interpreter::BytecodeArrayIterator& iterator) {
-  UNIMPLEMENTED();
+  BuildCall(iterator);
 }
 
 
+void BytecodeGraphBuilder::VisitCallWide(
+    const interpreter::BytecodeArrayIterator& iterator) {
+  BuildCall(iterator);
+}
+
+
 void BytecodeGraphBuilder::VisitCallRuntime(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCallJSRuntime(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
@@ skipping 415 matching lines @@
 
 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) {
   if (environment()->IsMarkedAsUnreachable()) return;
   environment()->MarkAsUnreachable();
   exit_controls_.push_back(exit);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8