Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1437863002: Run gn_unittests on Mac bots (Closed)

Created:
5 years, 1 month ago by tsniatowski
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run gn_unittests on Mac bots With Linux already there and Windows added recently this should make gn_unittests run on all relevant platforms in CQ. R=dpranke@chromium.org BUG=549254 Committed: https://crrev.com/4b9eab81427d0bc94372ce3ea8e84986cda03eac Cr-Commit-Position: refs/heads/master@{#359290}

Patch Set 1 #

Patch Set 2 : Add gn_unittests to all mac bots that run UTs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 1 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tsniatowski
PTAL. trybots were a bit so-so with unrelated flakes. I'm not sure if I should ...
5 years, 1 month ago (2015-11-11 16:23:20 UTC) #1
Dirk Pranke
mac_chromium_rel_ng picks up the list of tests it runs from "Mac10.8 Tests", so I'd probably ...
5 years, 1 month ago (2015-11-11 18:17:19 UTC) #2
tsniatowski
On 2015/11/11 18:17:19, Dirk Pranke wrote: > mac_chromium_rel_ng picks up the list of tests it ...
5 years, 1 month ago (2015-11-11 20:14:26 UTC) #3
Dirk Pranke
On 2015/11/11 20:14:26, tsniatowski wrote: > Added it to all the Mac bots that run ...
5 years, 1 month ago (2015-11-11 20:37:17 UTC) #4
tsniatowski
On 2015/11/11 20:37:17, Dirk Pranke wrote: > On 2015/11/11 20:14:26, tsniatowski wrote: > > Added ...
5 years, 1 month ago (2015-11-11 21:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437863002/20001
5 years, 1 month ago (2015-11-12 07:21:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 08:44:36 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b9eab81427d0bc94372ce3ea8e84986cda03eac
Cr-Commit-Position: refs/heads/master@{#359290}

Powered by Google App Engine
This is Rietveld 408576698