Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 143783002: Make it possible for the embedder to run unload handlers in subframes.

Created:
6 years, 11 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
Charlie Reis, alexmos
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Make it possible for the embedder to run unload handlers in subframes. This is needed to run unload handlers in subframes before the IPC filter is installed for cross-process swaps. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/loader/FrameLoader.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
This is one way to fix the problem. There are others.
5 years, 8 months ago (2015-04-10 18:22:38 UTC) #2
dcheng
Also, this patch needs to be rebased to ToT. The function called have moved around ...
5 years, 8 months ago (2015-04-10 18:24:10 UTC) #3
alexmos
5 years, 8 months ago (2015-04-10 23:41:43 UTC) #4
On 2015/04/10 18:24:10, dcheng wrote:
> Also, this patch needs to be rebased to ToT. The function called have moved
> around since then.
> 
> If we feel this patch is the right direction, I'll go ahead and update it.

I'm all for something like this.  To me it makes much more sense to run subframe
unload handlers together with the main frame's unload rather than when
navigating to swappedout:// after swapped_out_ becomes true.  And we'll need
something like this anyway to fire the subframe unload handlers when we get rid
of swappedout://, right?

Powered by Google App Engine
This is Rietveld 408576698