Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1437823006: Update login histogram owners. (Closed)

Created:
5 years, 1 month ago by achuithb
Modified:
5 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update login histogram owners. Remove people no longer working on the project and replace with self: nkostylev@, antrim@, rsorkin@, ginkage@ -> achuith@ Also take ownership of a few metrics. BUG=538294 Committed: https://crrev.com/852a774ab65d264245322d15ff3184e9cd60fc74 Cr-Commit-Position: refs/heads/master@{#359192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M tools/metrics/histograms/histograms.xml View 21 chunks +34 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437823006/1
5 years, 1 month ago (2015-11-11 22:18:51 UTC) #2
achuithb
Ilya, please review.
5 years, 1 month ago (2015-11-11 22:20:28 UTC) #5
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 1 month ago (2015-11-11 22:39:57 UTC) #7
Ilya Sherman
LGTM, thanks.
5 years, 1 month ago (2015-11-11 23:01:14 UTC) #8
achuithb
On 2015/11/11 23:01:14, Ilya Sherman wrote: > LGTM, thanks. ty
5 years, 1 month ago (2015-11-11 23:12:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437823006/1
5 years, 1 month ago (2015-11-11 23:13:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 00:22:01 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/852a774ab65d264245322d15ff3184e9cd60fc74
Cr-Commit-Position: refs/heads/master@{#359192}

Powered by Google App Engine
This is Rietveld 408576698