third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 1437813002: Set selection to INPUT/TEXTAREA before dispatching 'focus' event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1437813002: Set selection to INPUT/TEXTAREA before dispatching 'focus' event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improve selection-functions.html Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index 8c4f7685f09ca620d4b1d56328b58172793e5910..53ff7b69cc845cd49cd2d7d2d5ef6deb7c08785c 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -251,10 +251,7 @@ void HTMLTextAreaElement::updateFocusAppearance(SelectionBehaviorOnFocus selecti

restoreCachedSelection();

break;

case SelectionBehaviorOnFocus::None:

- // |None| is used only for FocusController::setFocusedElement and

- // Document::setFocusedElement, and they don't call

- // updateFocusAppearance().

- ASSERT_NOT_REACHED();

+ return;

}

if (document().frame())

document().frame()->selection().revealSelection();

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | no next file » | no next file with comments »