Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 14378006: Revert 195265 "Improved extension activity logging for the chrom..." (Closed)

Created:
7 years, 8 months ago by felt
Modified:
7 years, 8 months ago
Reviewers:
mvrable
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195265 "Improved extension activity logging for the chrom..." Hi Michael, drovering this for you while you fix the memory leak. > Improved extension activity logging for the chrome.webRequest API. > > Add a new type of log item in the activitylog_urls table: WEBREQUEST, > used to summarize the changes made to an HTTP request using the > blocking WebRequest extension API. The types of modifications made > are always logged when the extension activity log is enabled; the > details of the modification are only kept if the activity log testing > flag is enabled (as the details may contain sensitive data). > > BUG=169628 > > Review URL: https://chromiumcodereview.appspot.com/12491012 TBR=mvrable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -318 lines) Patch
MM trunk/src/chrome/browser/extensions/activity_log.h View 1 chunk +0 lines, -8 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/activity_log.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/chrome/browser/extensions/activity_log_web_request_constants.h View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/chrome/browser/extensions/activity_log_web_request_constants.cc View 1 chunk +0 lines, -33 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/api/web_request/web_request_api.cc View 4 chunks +2 lines, -165 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/dom_actions.h View 1 chunk +4 lines, -5 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/dom_actions.cc View 2 chunks +0 lines, -4 lines 0 comments Download
MM trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/activity_log/options.js View 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
felt
7 years, 8 months ago (2013-04-19 22:18:43 UTC) #1
felt
Committed patchset #1 manually as r195311.
7 years, 8 months ago (2013-04-19 22:19:02 UTC) #2
mvrable
7 years, 8 months ago (2013-04-19 22:29:00 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698