git_cl/gclient: use python2

git_cl/gclient: use python2

Newer distros are defaulting /usr/bin/python to python3, so use python2
explicitly so we continue working.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297535

[vapier, 2015-11-11 07:09:10]

vapier@chromium.org changed reviewers:
+ stip@chromium.org

[iannucci, 2015-11-11 07:20:45]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2015-11-11 07:20:45]

pretty sure this will break mac

$ which python2
python2 not found
$ which python2.7
/usr/bin/python2.7

[vapier, 2015-11-11 07:26:47]

python says there's supposed to be a python2 symlink:
https://www.python.org/dev/peps/pep-0394/

but that doesn't help if OS X is dumb and doesn't follow the pep.  i could
switch it to python2.7 as it's highly unlikely there will be a 2.8.

[iannucci, 2015-11-11 07:28:52]

On 2015/11/11 at 07:26:47, vapier wrote:
> python says there's supposed to be a python2 symlink:
> https://www.python.org/dev/peps/pep-0394/
> 
> but that doesn't help if OS X is dumb and doesn't follow the pep.  i could
switch it to python2.7 as it's highly unlikely there will be a 2.8.

Maybe it's fixed in 10.11, but it's at least not there on 10.10. ¯\_(ツ)_/¯

Making it python2.7 should work on both linux and mac tho I think.

[vapier, 2015-11-11 07:34:58]

do you know what's responsible for installing that ?  is it xcode ?  or does it
come on OS X ?

the Mac Build Instructions doesn't seem to get into that level of detail.

[iannucci, 2015-11-11 07:43:19]

On 2015/11/11 at 07:34:58, vapier wrote:
> do you know what's responsible for installing that ?  is it xcode ?  or does
it come on OS X ?
> 
> the Mac Build Instructions doesn't seem to get into that level of detail.

I think it's just the one that comes with OS X. Mine shows up as
`/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python`

[iannucci, 2015-11-11 23:07:53]

iannucci@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[iannucci, 2015-11-11 23:07:54]

lgtm

+current trooper

[Sergey Berezin, 2015-11-11 23:47:33]

LGTM, thanks. 
Looks simple enough, I'm sure nothing can go wrong... :-)

[vapier, 2015-11-12 01:56:22]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2015-11-12 01:56:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437773002/20001

[vapier, 2015-11-12 01:56:34]

there's always the revert hammer ;)

[commit-bot: I haz the power, 2015-11-12 02:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 02:28:35]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[vapier, 2015-11-12 05:29:12]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2015-11-12 05:29:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437773002/20001

[commit-bot: I haz the power, 2015-11-12 05:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 05:33:37]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[vapier, 2015-11-12 05:47:57]

The CQ bit was checked by vapier@chromium.org

[vapier, 2015-11-12 05:47:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1437773002/#ps40001
(title: "update path used in unittest")

[commit-bot: I haz the power, 2015-11-12 05:48:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437773002/40001

[commit-bot: I haz the power, 2015-11-12 05:50:02]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297535

[Geoff Lang, 2015-11-12 17:22:23]

I found that this breaks gclient on Windows using git-bash:

$ gclient sync
/d/code/depot_tools/gclient: line 12: exec: python2.7: not found

[iannucci, 2015-11-12 18:08:11]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1442583004/ by iannucci@chromium.org.

The reason for reverting is: breaks git-bash on windows.