Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1437763002: dump_syms: add a -v flag (Closed)

Created:
5 years, 1 month ago by vapier
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dump_syms: add a -v flag dump_syms generates a lot of warnings. This CL puts logging behind a command line flag URL=https://android-review.googlesource.com/181558 BUG=b:25460551 BUG=google-breakpad:441 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/9e60a27911516aa4c74565ebff133fe421dfb029

Patch Set 1 #

Total comments: 2

Patch Set 2 : address mark's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/tools/linux/dump_syms/dump_syms.cc View 1 6 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vapier
5 years, 1 month ago (2015-11-11 06:45:07 UTC) #1
vapier
5 years, 1 month ago (2015-11-11 06:45:42 UTC) #4
Mark Mentovai
Sure, why not? LGTM. https://codereview.chromium.org/1437763002/diff/1/src/tools/linux/dump_syms/dump_syms.cc File src/tools/linux/dump_syms/dump_syms.cc (right): https://codereview.chromium.org/1437763002/diff/1/src/tools/linux/dump_syms/dump_syms.cc#newcode77 src/tools/linux/dump_syms/dump_syms.cc:77: FILE* saved_stderr = fdopen(dup(STDERR_FILENO), "w"); ...
5 years, 1 month ago (2015-11-11 15:05:13 UTC) #5
vapier
5 years, 1 month ago (2015-11-11 18:52:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9e60a27911516aa4c74565ebff133fe421dfb029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698