Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 1437623003: Revert of ui: Add custom stride support to GLImageMemory. (Closed)

Created:
5 years, 1 month ago by Peter Mayo
Modified:
5 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Add custom stride support to GLImageMemory. (patchset #3 id:40001 of https://codereview.chromium.org/1403283007/ ) Reason for revert: int versus size_t problem on Windows. Please correct and re-land Original issue's description: > ui: Add custom stride support to GLImageMemory. > > This improves our support for shared memory pools by allowing > clients to create GLImages with a stride that is larger than > the row length of the image. > > This makes it possible to import a buffer with a stride that > doesn't match the aligned row size. However, support for > mapping of such a buffer is not provided by this patch. > > BUG=549781 > TEST=gl_unittests --gtest_filter=GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/8b0062c4a359ee651b7fb23707bf3aaf20162990 > Cr-Commit-Position: refs/heads/master@{#358835} TBR=fsamuel@chromium.org,piman@chromium.org,wfh@chromium.org,avi@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -214 lines) Patch
M cc/test/test_gpu_memory_buffer_manager.cc View 5 chunks +4 lines, -11 lines 0 comments Download
M cc/test/test_image_factory.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/child_process_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 7 chunks +4 lines, -12 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 2 chunks +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 3 chunks +1 line, -8 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_image_memory.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 12 chunks +45 lines, -122 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/gl/gl_image_shared_memory.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M ui/gl/gl_image_shared_memory_unittest.cc View 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Peter Mayo
Created Revert of ui: Add custom stride support to GLImageMemory.
5 years, 1 month ago (2015-11-10 16:48:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437623003/1
5 years, 1 month ago (2015-11-10 16:49:33 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-11-10 16:50:42 UTC) #4
Will Harris
5 years, 1 month ago (2015-11-10 16:52:16 UTC) #6
this was already reverted by avi@ in crrev.com/1427413004

Powered by Google App Engine
This is Rietveld 408576698