sdk/lib/io/websocket_impl.dart - Issue 1437623002: Ensure proper response to chrome client_max_window_bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 1437623002: Ensure proper response to chrome client_max_window_bits (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Always send client_max_window_bits on response Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/websocket_impl.dart

diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart

index bcb800d84aa80e8f4ca0d812f641b231012f9336..4f00a17a94cd76157157be9ba0933353b26f80bd 100644

--- a/sdk/lib/io/websocket_impl.dart

+++ b/sdk/lib/io/websocket_impl.dart

@@ -458,9 +458,7 @@ class _WebSocketTransformerImpl implements WebSocketTransformer {

HttpResponse response, CompressionOptions compression) {

var extensionHeader = request.headers.value("Sec-WebSocket-Extensions");

- if (extensionHeader == null) {

- extensionHeader = "";

- }

+ extensionHeader ??= "";

var hv = HeaderValue.parse(extensionHeader, valueSeparator: ',');

if (compression.enabled && hv.value == _WebSocketImpl.PER_MESSAGE_DEFLATE) {

« sdk/lib/io/websocket.dart ('K') | « sdk/lib/io/websocket.dart ('k') | no next file » | no next file with comments »