Ensure proper response to chrome client_max_window_bits

Ensure proper response to chrome client_max_window_bits request.

I undid the patch John McCutchan did to disable compression and compiled and verify that Chrome does not experience any issues with websocket compression negotiation and that compression is enabled.

Also tested with observatory on Firefox and Edge (IE) and both work with current configuration.

BUG=#24864
subject: Ensure proper response to chrome client_max_window_bits

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/bcd7466b562e1ac873e9a7309ca95eb9b84f723e

[butlermatt, 2015-11-10 18:13:26]

Description was changed from

==========
Ensure proper response to chrome client_max_window_bits

BUG=#24864
==========

to

==========
Ensure proper response to chrome client_max_window_bits request.

I undid the patch John McCutchan did to disable compression and compiled and
verify that Chrome does not experience any issues with websocket compression
negotiation and that compression is enabled.

Also tested with observatory on Firefox and Edge (IE) and both work with current
configuration.

BUG=#24864
subject: Ensure proper response to chrome client_max_window_bits
==========

[butlermatt, 2015-11-10 18:13:26]

butler.matthew@gmail.com changed reviewers:
+ johnmccutchan@google.com, kaendfinger@gmail.com, sgjesse@google.com

[butlermatt, 2015-11-10 18:15:19]

This should resolve issue with Observatory running in Chrome per bug: 
https://github.com/dart-lang/sdk/issues/24864

Matt

[butlermatt, 2015-11-11 13:01:03]

butler.matthew@gmail.com changed reviewers:
+ whesse@google.com

[butlermatt, 2015-11-11 13:01:04]

Fixed method return type noticed by William Hesse on github, cc'd as reviewer
here too.

[Søren Gjesse, 2015-11-11 13:31:08]

Thanks for fixing this.

Please add a test where an http client sends the same headers as Chrome is
currently sending. You can just test that the server responds with the right
headers, or even change to WebSocket by using WebSocket.fromUpgradedSocket
(after detaching the socket from the http request). However, it might be that
WebSocket.fromUpgradedSocket needs to be updated to handle a connection where
compression was negotiated.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:82: /// [WebSocket.DEFAULT_WINDOW_BITS]
Please update the documentation to explain the two element list returned.

Actually please use an instance of a class with two meaningful fields.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:110: List _createClientRequestHeader(HeaderValue
requested, int size) {
This is no longer returning a List.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:128: List _createHeader([HeaderValue requested]) {
See above.

[butlermatt, 2015-11-11 18:26:31]

I've refactored the _createHeader methods to use a new descriptive class rather
than a List.

Added a test which will test against different values for Websocket header
"Sec-WebSocket-Extensions". Currently testing against the values sent by chrome
and by firefox.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:82: /// [WebSocket.DEFAULT_WINDOW_BITS]
On 2015/11/11 13:31:08, Søren Gjesse wrote:
> Please update the documentation to explain the two element list returned.
> 
> Actually please use an instance of a class with two meaningful fields.

Done.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:110: List _createClientRequestHeader(HeaderValue
requested, int size) {
On 2015/11/11 13:31:08, Søren Gjesse wrote:
> This is no longer returning a List.

Done.

https://codereview.chromium.org/1437623002/diff/20001/sdk/lib/io/websocket.da...
sdk/lib/io/websocket.dart:128: List _createHeader([HeaderValue requested]) {
On 2015/11/11 13:31:08, Søren Gjesse wrote:
> See above.

Done.

[butlermatt, 2015-11-11 18:31:43]

Minor update to new test to make it more configurable.

[butlermatt, 2015-11-11 20:06:29]

I added another test to verify window sizes decreased on demand.

As a result of this test failing, I fixed a bug in which window sizes would not
vary from default size.

[Søren Gjesse, 2015-11-12 16:01:33]

LGTM

Good to see that the tests revealed something.

[Søren Gjesse, 2015-11-12 16:04:17]

Committed patchset #6 (id:100001) manually as
bcd7466b562e1ac873e9a7309ca95eb9b84f723e (presubmit successful).

[kevmoo, 2015-11-12 19:21:43]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-11-12 19:21:44]

We should have browser-based tests for this implementation as well.

Keneth?

[butlermatt, 2015-11-12 19:39:01]

On 2015/11/12 19:21:44, kevmoo wrote:
> We should have browser-based tests for this implementation as well.
> 
> Keneth?

Hi Kevin,

I'd be happy to add tests for it, but since this is a dart:io only change, all
we can test in the browser is the response from a server and if that response
causes the browser to blow up or not. Do we have any existing tests where we
validate dart:io responses in the browser that I can use as a template to
elaborate on?

Thanks,

Matt