Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1437553002: Add some race-detector tests (Closed)

Created:
5 years, 1 month ago by iannucci
Modified:
5 years, 1 month ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add some race-detector tests The impl/memory one is fine, but the txnBuf one is currently failing. R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/013f2ca6914c1a8f3fc7e62c29a432cdeffecca5

Patch Set 1 #

Total comments: 5

Patch Set 2 : upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -0 lines) Patch
A filter/txnBuf/race_test.go View 1 chunk +62 lines, -0 lines 0 comments Download
A impl/memory/race_test.go View 1 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
iannucci
5 years, 1 month ago (2015-11-09 23:25:00 UTC) #1
dnj
https://chromiumcodereview.appspot.com/1437553002/diff/1/impl/memory/race_test.go File impl/memory/race_test.go (right): https://chromiumcodereview.appspot.com/1437553002/diff/1/impl/memory/race_test.go#newcode19 impl/memory/race_test.go:19: value := new(int64) nit: int64(0), use &value elsewhere. https://chromiumcodereview.appspot.com/1437553002/diff/1/impl/memory/race_test.go#newcode55 ...
5 years, 1 month ago (2015-11-10 00:20:20 UTC) #2
iannucci
ptal https://chromiumcodereview.appspot.com/1437553002/diff/1/impl/memory/race_test.go File impl/memory/race_test.go (right): https://chromiumcodereview.appspot.com/1437553002/diff/1/impl/memory/race_test.go#newcode19 impl/memory/race_test.go:19: value := new(int64) On 2015/11/10 at 00:20:20, dnj ...
5 years, 1 month ago (2015-11-11 18:13:58 UTC) #3
dnj
lgtm
5 years, 1 month ago (2015-11-11 18:14:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437553002/20001
5 years, 1 month ago (2015-11-11 18:15:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 18:19:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/013f2ca6914c1a8f3fc7e62c29a432cdeffecca5

Powered by Google App Engine
This is Rietveld 408576698