[MD settings] adding page zoom options to appearnce settings

chrome/browser/resources/settings/appearance_page/appearance_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * 'settings-appearance-page' is the settings page containing appearance
  * settings.
  *
  * Example:
  *
@@ skipping 12 matching lines @@
   properties: {
     /**
      * The current active route.
      */
     currentRoute: {
       notify: true,
       type: Object,
     },
 
     /**
+     * Preferences state.
+     */
+    prefs: {
+      type: Object,
+      notify: true,
+    },
+
+    /**
      * @private
      */
     allowResetTheme_: {
       notify: true,
       type: Boolean,
       value: false,
     },
 
     /**
+     * @private
+     */
+    defaultZoomLevel_: {
+      notify: true,
+      type: Object,
+      value: function() {
+        return {value: undefined};
+      },
+    },
+
+    /**
      * List of options for the font size drop-down menu.
      * The order of entries in this array matches the
      * prefs.browser.clear_data.time_period.value enum.
-     * @private {!Array<!Array<{0: number, 1: string}>>}
+     * @private {!Array<!Array<number, string>>}
      */
     fontSizeOptions_: {
       readOnly: true,
       type: Array,
       value: function() {
         return [
           [9, loadTimeData.getString('verySmall')],
           [12, loadTimeData.getString('small')],
           [16, loadTimeData.getString('medium')],
           [20, loadTimeData.getString('large')],
           [24, loadTimeData.getString('veryLarge')],
         ];
       },
     },
+
+    /**
+     * List of options for the page zoom drop-down menu.
+     * The order of entries in this array matches the
+     * prefs.browser.clear_data.time_period.value enum.

[michaelpg, 2015/11/09 23:59:45]

wat

[dschuyler, 2015/11/10 20:03:39]

The same could apply to the fontSizeOptions_ above.

Done.

+     * @private {!Array<!Array<number, string>>}
+     */
+    pageZoomOptions_: {
+      readOnly: true,
+      type: Array,
+      value: [
+        [25, '25%'],
+        [33, '33%'],
+        [50, '50%'],
+        [67, '67%'],
+        [75, '75%'],
+        [90, '90%'],
+        [100, '100%'],
+        [110, '110%'],
+        [125, '125%'],
+        [150, '150%'],
+        [175, '175%'],
+        [200, '200%'],
+        [300, '300%'],
+        [400, '400%'],
+        [500, '500%'],
+      ],
+    },
   },
 
   behaviors: [
     I18nBehavior,
   ],
 
+  observers: [
+    'zoomLevelChanged_(defaultZoomLevel_.value)',
+  ],
+
   ready: function() {
     this.$.defaultFontSize.menuOptions = this.fontSizeOptions_;
+    this.$.pageZoom.menuOptions = this.pageZoomOptions_;
+    chrome.settingsPrivate.getDefaultZoomPercent(
+        this.zoomPrefChanged_.bind(this));
   },
 
   /** @override */
   attached: function() {
     // Query the initial state.
     cr.sendWithCallback('getResetThemeEnabled', undefined,
                         this.setResetThemeEnabled.bind(this));
 
     // Set up the change event listener.
     cr.addWebUIListener('reset-theme-enabled-changed',
                         this.setResetThemeEnabled.bind(this));
   },
 
   /**
    * @param {boolean} enabled Whether the theme reset is available.
    */
   setResetThemeEnabled: function(enabled) {
     this.allowResetTheme_ = enabled;
   },
 
   /** @private */
   onCustomizeFontsTap_: function() {
     this.$.pages.setSubpageChain(['appearance-fonts']);
   },
 
   /** @private */
+  onCustomizeFontsTap_: function() {

[michaelpg, 2015/11/09 23:59:45]

wat

[dschuyler, 2015/11/10 20:03:39]

I seem to have had some trouble merging code.

Done.

[Dan Beam, 2015/11/10 22:21:26]

the review tools, turns out, can still be used to view your own code before
sending it to others, btw ;)

+    this.$.pages.setSubpageChain(['appearance-fonts']);
+  },
+
+  /** @private */
   openThemesGallery_: function() {
     window.open(loadTimeData.getString('themesGalleryUrl'));
   },
 
   /** @private */
   resetTheme_: function() {
     chrome.send('resetTheme');
   },
+
+  zoomPrefChanged_: function(percent) {
+    this.set('defaultZoomLevel_.value', percent);
+  },
+
+  zoomLevelChanged_: function(percent) {
+    // The |percent| may be undefined on startup.
+    if (percent === undefined)
+      return;
+    chrome.settingsPrivate.setDefaultZoomPercent(percent);
+  },
 });