Revert "URLRequestJob: change ReadRawData contract"

Revert "URLRequestJob: change ReadRawData contract"

This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225.

Revert "Disable http/tests/serviceworker/registration.html"

This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322.

Revert "Remove incorrect DCHECK_NE in ServiceWorkerWriteToCacheJob::OnReadCompleted."

This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b.

Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if ERR_IO_PENDING"

This reverts commit 876da269322a66d5e2741de0892e01b24ab98065.

TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org
BUG=553300
BUG=474859
Committed: https://crrev.com/8f4440075845550559c09a787bf71de915d4cfc5
Cr-Commit-Position: refs/heads/master@{#358686}

[xunjieli, 2015-11-09 21:04:34]

xunjieli@chromium.org changed reviewers:
+ mmenke@chromium.org, rdsmith@chromium.org

[xunjieli, 2015-11-09 21:04:35]

PTAL.
Running try jobs in the meantime.

[xunjieli, 2015-11-09 21:06:26]

Description was changed from

==========
Revert "URLRequestJob: change ReadRawData contract"

This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225.

Revert "Disable http/tests/serviceworker/registration.html"

This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322.

Revert "Remove incorrect DCHECK_NE in
ServiceWorkerWriteToCacheJob::OnReadCompleted."

This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b.

Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if
ERR_IO_PENDING"

This reverts commit 876da269322a66d5e2741de0892e01b24ab98065.

BUG=553300
==========

to

==========
Revert "URLRequestJob: change ReadRawData contract"

This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225.

Revert "Disable http/tests/serviceworker/registration.html"

This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322.

Revert "Remove incorrect DCHECK_NE in
ServiceWorkerWriteToCacheJob::OnReadCompleted."

This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b.

Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if
ERR_IO_PENDING"

This reverts commit 876da269322a66d5e2741de0892e01b24ab98065.

BUG=553300
BUG=474859
==========

[Randy Smith (Not in Mondays), 2015-11-09 21:17:24]

If the try jobs are clean, then LGTM.

[mmenke, 2015-11-09 21:17:41]

On 2015/11/09 21:04:35, xunjieli wrote:
> PTAL.
> Running try jobs in the meantime.

LGTM.

[xunjieli, 2015-11-09 21:18:33]

Description was changed from

==========
Revert "URLRequestJob: change ReadRawData contract"

This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225.

Revert "Disable http/tests/serviceworker/registration.html"

This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322.

Revert "Remove incorrect DCHECK_NE in
ServiceWorkerWriteToCacheJob::OnReadCompleted."

This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b.

Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if
ERR_IO_PENDING"

This reverts commit 876da269322a66d5e2741de0892e01b24ab98065.

BUG=553300
BUG=474859
==========

to

==========
Revert "URLRequestJob: change ReadRawData contract"

This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225.

Revert "Disable http/tests/serviceworker/registration.html"

This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322.

Revert "Remove incorrect DCHECK_NE in
ServiceWorkerWriteToCacheJob::OnReadCompleted."

This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b.

Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if
ERR_IO_PENDING"

This reverts commit 876da269322a66d5e2741de0892e01b24ab98065.

TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugeneb...,
sky@chromium.org,jianli@chromium.org,zork@chromium.org
BUG=553300
BUG=474859
==========

[xunjieli, 2015-11-09 21:19:06]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2015-11-09 21:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437523002/1

[xunjieli, 2015-11-09 21:20:59]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2015-11-09 21:23:50]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2015-11-09 21:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437523002/1

[commit-bot: I haz the power, 2015-11-09 22:36:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-09 22:37:53]

Patchset 1 (id:??) landed as
https://crrev.com/8f4440075845550559c09a787bf71de915d4cfc5
Cr-Commit-Position: refs/heads/master@{#358686}

[msw, 2015-11-09 23:37:58]

msw@chromium.org changed reviewers:
+ jam@chromium.org, msw@chromium.org

[msw, 2015-11-09 23:37:59]

Hmm, it looks like this broke
UrlLoaderImplTest.ClosedWhileWaitingOnThePipeToBeWriteable in mojo_apptests on
"Linux Tests" and "Chromium Mojo Linux":
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34038
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
There might be some conflict with jam's
https://codereview.chromium.org/1434563004 (hence passing the CQ), John is
reverting that CL now to see if that helps.

[msw, 2015-11-09 23:51:43]

On 2015/11/09 23:37:59, msw wrote:
> Hmm, it looks like this broke
> UrlLoaderImplTest.ClosedWhileWaitingOnThePipeToBeWriteable in mojo_apptests on
> "Linux Tests" and "Chromium Mojo Linux":
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34038
>
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
> There might be some conflict with jam's
> https://codereview.chromium.org/1434563004 (hence passing the CQ), John is
> reverting that CL now to see if that helps.

"Chromium Mojo Linux" cycled green after jam's revert:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
The same should hopefully happen on "Linux Tests", if so, no action will be
required here.

[msw, 2015-11-10 01:16:18]

On 2015/11/09 23:51:43, msw wrote:
> On 2015/11/09 23:37:59, msw wrote:
> > Hmm, it looks like this broke
> > UrlLoaderImplTest.ClosedWhileWaitingOnThePipeToBeWriteable in mojo_apptests
on
> > "Linux Tests" and "Chromium Mojo Linux":
> >
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34038
> >
>
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
> > There might be some conflict with jam's
> > https://codereview.chromium.org/1434563004 (hence passing the CQ), John is
> > reverting that CL now to see if that helps.
> 
> "Chromium Mojo Linux" cycled green after jam's revert:
>
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
> The same should hopefully happen on "Linux Tests", if so, no action will be
> required here.

"Linux Tests" cycled green too, no action required here:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34040

[xunjieli, 2015-11-10 13:52:57]

On 2015/11/10 01:16:18, msw wrote:
> On 2015/11/09 23:51:43, msw wrote:
> > On 2015/11/09 23:37:59, msw wrote:
> > > Hmm, it looks like this broke
> > > UrlLoaderImplTest.ClosedWhileWaitingOnThePipeToBeWriteable in
mojo_apptests
> on
> > > "Linux Tests" and "Chromium Mojo Linux":
> > >
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34038
> > >
> >
>
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
> > > There might be some conflict with jam's
> > > https://codereview.chromium.org/1434563004 (hence passing the CQ), John is
> > > reverting that CL now to see if that helps.
> > 
> > "Chromium Mojo Linux" cycled green after jam's revert:
> >
>
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/bu...
> > The same should hopefully happen on "Linux Tests", if so, no action will be
> > required here.
> 
> "Linux Tests" cycled green too, no action required here:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/34040

Thanks for taking care of the tests. Hope jam@ can re-land his CL soon.