Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Issue 1437493002: Improved some tests in test-run-machops. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improved some tests in test-run-machops. I improved the tests for Word32Clz, Word32Ctz, and Word32Popcnt, and ported some tests to the BufferedRawMachineAssemblerTester. R=titzer@chromium.org Committed: https://crrev.com/7558e933474359a7ced2c620100dcd2f8e42057e Cr-Commit-Position: refs/heads/master@{#31896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -425 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 6 chunks +149 lines, -425 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahaas
5 years, 1 month ago (2015-11-09 15:47:12 UTC) #1
titzer
lgtm
5 years, 1 month ago (2015-11-09 17:39:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437493002/1
5 years, 1 month ago (2015-11-09 17:40:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 17:41:41 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 17:42:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7558e933474359a7ced2c620100dcd2f8e42057e
Cr-Commit-Position: refs/heads/master@{#31896}

Powered by Google App Engine
This is Rietveld 408576698