Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 143743005: [Mac, Win] New avatar bubble should be a fixed width. (Closed)

Created:
6 years, 11 months ago by noms (inactive)
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac, Win] New avatar bubble should be a fixed width. This involves eliding ALL the things: the active profile name, the names of other profiles in the fast profile switcher, and the text of the big blue "add account for x" button. Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMQXJ5VXFxSmwxNVE&usp=sharing BUG=334761

Patch Set 1 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -32 lines) Patch
M chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm View 9 chunks +53 lines, -20 lines 5 comments Download
M chrome/browser/ui/views/profile_chooser_view.cc View 11 chunks +59 lines, -12 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
noms (inactive)
Hi, Here's some more work on the new avatar bubble that makes sure the bubble ...
6 years, 11 months ago (2014-01-22 22:17:50 UTC) #1
sky
https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/views/profile_chooser_view.cc File chrome/browser/ui/views/profile_chooser_view.cc (right): https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/views/profile_chooser_view.cc#newcode263 chrome/browser/ui/views/profile_chooser_view.cc:263: base::string16 elided_name = ElideText(text, You shouldn't need to elide ...
6 years, 11 months ago (2014-01-23 01:00:52 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm File chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm (right): https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm#newcode97 chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm:97: ui::ResourceBundle::FontStyle fontStyle) { font_style, since this is a C++ ...
6 years, 11 months ago (2014-01-23 15:41:40 UTC) #3
Alexei Svitkine (slow)
6 years, 11 months ago (2014-01-23 15:42:05 UTC) #4
https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm (right):

https://codereview.chromium.org/143743005/diff/400001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm:64: const CGFloat
kFixedMenuWidth = 250;
Can these be defined in some shared location?

Powered by Google App Engine
This is Rietveld 408576698