cc/trees/layer_tree_host_unittest_animation_timelines.cc - Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_animation_timelines.cc

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just the vector Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host_impl_unittest.cc ('K') | « cc/trees/layer_tree_host_unittest_animation.cc ('k') | cc/trees/layer_tree_host_unittest_context.cc » ('j') | cc/trees/layer_tree_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/trees/layer_tree_host_unittest_animation_timelines.cc

diff --git a/cc/trees/layer_tree_host_unittest_animation_timelines.cc b/cc/trees/layer_tree_host_unittest_animation_timelines.cc

index 69c42efa9547f2559e2c96da96f0eadf08abce98..30b69ee1fb38692d59440014c940dbfa3239e549 100644

--- a/cc/trees/layer_tree_host_unittest_animation_timelines.cc

+++ b/cc/trees/layer_tree_host_unittest_animation_timelines.cc

@@ -658,7 +658,7 @@ class LayerTreeHostTimelinesTestScrollOffsetAnimationRemoval

timeline_impl->GetPlayerById(player_child_id_);

LayerImpl* scroll_layer_impl =

- host_impl->active_tree()->root_layer()->children()[0];

+ host_impl->active_tree()->root_layer()->children()[0].get();

Animation* animation = player_impl->element_animations()

->layer_animation_controller()

->GetAnimation(Animation::SCROLL_OFFSET);

@@ -681,7 +681,7 @@ class LayerTreeHostTimelinesTestScrollOffsetAnimationRemoval

if (host_impl->pending_tree()->source_frame_number() != 1)

return;

LayerImpl* scroll_layer_impl =

- host_impl->pending_tree()->root_layer()->children()[0];

+ host_impl->pending_tree()->root_layer()->children()[0].get();

EXPECT_EQ(final_postion_, scroll_layer_impl->CurrentScrollOffset());

}

@@ -689,7 +689,7 @@ class LayerTreeHostTimelinesTestScrollOffsetAnimationRemoval

if (host_impl->active_tree()->source_frame_number() != 1)

return;

LayerImpl* scroll_layer_impl =

- host_impl->active_tree()->root_layer()->children()[0];

+ host_impl->active_tree()->root_layer()->children()[0].get();

EXPECT_EQ(final_postion_, scroll_layer_impl->CurrentScrollOffset());

EndTest();

}

@@ -970,7 +970,7 @@ class LayerTreeHostTimelinesTestAnimationFinishesDuringCommit

gfx::Transform expected_transform;

expected_transform.Translate(5.f, 5.f);

LayerImpl* layer_impl =

- host_impl->sync_tree()->root_layer()->children()[0];

+ host_impl->sync_tree()->root_layer()->children()[0].get();

EXPECT_EQ(expected_transform, layer_impl->draw_transform());

EndTest();

break;