Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3577)

Unified Diff: cc/surfaces/surface.cc

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just the vector Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface.cc
diff --git a/cc/surfaces/surface.cc b/cc/surfaces/surface.cc
index 32f41f1e050a29142e22b7266901a43fabfa3278..76b21b3c073a622eb63649c49fa926d1fa697a98 100644
--- a/cc/surfaces/surface.cc
+++ b/cc/surfaces/surface.cc
@@ -6,6 +6,7 @@
#include <algorithm>
+#include "cc/base/container_util.h"
#include "cc/output/compositor_frame.h"
#include "cc/output/copy_output_request.h"
#include "cc/surfaces/surface_factory.h"
@@ -116,8 +117,7 @@ void Surface::TakeCopyOutputRequests(
current_frame_->delegated_frame_data->render_pass_list) {
while (!render_pass->copy_requests.empty()) {
scoped_ptr<CopyOutputRequest> request =
- render_pass->copy_requests.take_back();
- render_pass->copy_requests.pop_back();
+ TakeBack(&render_pass->copy_requests);
copy_requests->insert(
std::make_pair(render_pass->id, request.release()));
danakj 2015/11/17 01:12:17 can you put a TODO and a bug to make this multimap
vmpstr 2015/11/17 23:26:24 I'll do this as a follow-up. Added a TODO.
}

Powered by Google App Engine
This is Rietveld 408576698