Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: cc/quads/render_pass.cc

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just the vector Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/quads/render_pass.cc
diff --git a/cc/quads/render_pass.cc b/cc/quads/render_pass.cc
index dc79bb8baf4dc013208e2a3541f91a2ecf7e10c0..9a73da1adba88ecece31e2589511f12f3a000239 100644
--- a/cc/quads/render_pass.cc
+++ b/cc/quads/render_pass.cc
@@ -92,10 +92,10 @@ scoped_ptr<RenderPass> RenderPass::Copy(RenderPassId new_id) const {
}
// static
-void RenderPass::CopyAll(const ScopedPtrVector<RenderPass>& in,
- ScopedPtrVector<RenderPass>* out) {
+void RenderPass::CopyAll(const std::vector<scoped_ptr<RenderPass>>& in,
+ std::vector<scoped_ptr<RenderPass>>* out) {
for (size_t i = 0; i < in.size(); ++i) {
danakj 2015/11/17 01:12:17 ouch. should be range-based too. whyyyy does it ha
vmpstr 2015/11/17 23:26:24 Done.
- RenderPass* source = in[i];
+ RenderPass* source = in[i].get();
// Since we can't copy these, it's wrong to use CopyAll in a situation where
// you may have copy_requests present.

Powered by Google App Engine
This is Rietveld 408576698