cc/PRESUBMIT.py - Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just the vector Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index c8506182da1878681437f25297c1886f1995e862..f044943f4ee4e39839014300499e0d42352a0a3b 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -247,9 +247,7 @@ def CheckNamespace(input_api, output_api):

contents = input_api.ReadFile(f, 'rb')

match = re.search(r'namespace\s*cc\s*{', contents)

if match:

- whitelist = [

- r"cc::remove_if\b",

- ]

+ whitelist = []

if FindNamespaceInBlock(match.end(), 'cc', contents, whitelist=whitelist):

errors.append(f.LocalPath())