cc: Remove ScopedPtrVector and cc::remove_if.

cc/tiles/eviction_tile_priority_queue.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tiles/eviction_tile_priority_queue.h"
 
 namespace cc {
 
 namespace {
 
 class EvictionOrderComparator {
  public:
   explicit EvictionOrderComparator(TreePriority tree_priority)
       : tree_priority_(tree_priority) {}
 
-  bool operator()(const TilingSetEvictionQueue* a_queue,
-                  const TilingSetEvictionQueue* b_queue) const {
+  bool operator()(const scoped_ptr<TilingSetEvictionQueue>& a_queue,
+                  const scoped_ptr<TilingSetEvictionQueue>& b_queue) const {
     // Note that in this function, we have to return true if and only if
     // b is strictly lower priority than a.
     const PrioritizedTile& a_tile = a_queue->Top();
     const PrioritizedTile& b_tile = b_queue->Top();
 
     const TilePriority& a_priority = a_tile.priority();
     const TilePriority& b_priority = b_tile.priority();
     bool prioritize_low_res = tree_priority_ == SMOOTHNESS_TAKES_PRIORITY;
 
     // If the priority bin differs, b is lower priority if it has the higher
@@ skipping 29 matching lines @@
     return b_priority.distance_to_visible > a_priority.distance_to_visible;
   }
 
  private:
   TreePriority tree_priority_;
 };
 
 void CreateTilingSetEvictionQueues(
     const std::vector<PictureLayerImpl*>& layers,
     TreePriority tree_priority,
-    ScopedPtrVector<TilingSetEvictionQueue>* queues) {
+    std::vector<scoped_ptr<TilingSetEvictionQueue>>* queues) {
   DCHECK(queues->empty());
 
   for (auto* layer : layers) {
     scoped_ptr<TilingSetEvictionQueue> tiling_set_queue = make_scoped_ptr(
         new TilingSetEvictionQueue(layer->picture_layer_tiling_set()));
     // Queues will only contain non empty tiling sets.
     if (!tiling_set_queue->IsEmpty())
       queues->push_back(tiling_set_queue.Pass());
   }
-  queues->make_heap(EvictionOrderComparator(tree_priority));
+  std::make_heap(queues->begin(), queues->end(),
+                 EvictionOrderComparator(tree_priority));
 }
 
 }  // namespace
 
 EvictionTilePriorityQueue::EvictionTilePriorityQueue() {
 }
 
 EvictionTilePriorityQueue::~EvictionTilePriorityQueue() {
 }
 
 void EvictionTilePriorityQueue::Build(
     const std::vector<PictureLayerImpl*>& active_layers,
     const std::vector<PictureLayerImpl*>& pending_layers,
     TreePriority tree_priority) {
   tree_priority_ = tree_priority;
 
   CreateTilingSetEvictionQueues(active_layers, tree_priority, &active_queues_);
   CreateTilingSetEvictionQueues(pending_layers, tree_priority,
                                 &pending_queues_);
 }
 
 bool EvictionTilePriorityQueue::IsEmpty() const {
   return active_queues_.empty() && pending_queues_.empty();
 }
 
 const PrioritizedTile& EvictionTilePriorityQueue::Top() const {
   DCHECK(!IsEmpty());
-  const ScopedPtrVector<TilingSetEvictionQueue>& next_queues = GetNextQueues();
+  const std::vector<scoped_ptr<TilingSetEvictionQueue>>& next_queues =

[danakj, 2015/11/17 01:12:18]

auto

[vmpstr, 2015/11/17 23:26:24]

Done.

+      GetNextQueues();
   return next_queues.front()->Top();
 }
 
 void EvictionTilePriorityQueue::Pop() {
   DCHECK(!IsEmpty());
 
-  ScopedPtrVector<TilingSetEvictionQueue>& next_queues = GetNextQueues();
-  next_queues.pop_heap(EvictionOrderComparator(tree_priority_));
-  TilingSetEvictionQueue* queue = next_queues.back();
+  std::vector<scoped_ptr<TilingSetEvictionQueue>>& next_queues =

[danakj, 2015/11/17 01:12:18]

auto?

[vmpstr, 2015/11/17 23:26:24]

Done.

+      GetNextQueues();
+  std::pop_heap(next_queues.begin(), next_queues.end(),
+                EvictionOrderComparator(tree_priority_));
+  TilingSetEvictionQueue* queue = next_queues.back().get();
   queue->Pop();
 
   // Remove empty queues.
-  if (queue->IsEmpty())
+  if (queue->IsEmpty()) {
     next_queues.pop_back();
-  else
-    next_queues.push_heap(EvictionOrderComparator(tree_priority_));
+  } else {
+    std::push_heap(next_queues.begin(), next_queues.end(),
+                   EvictionOrderComparator(tree_priority_));
+  }
 }
 
-ScopedPtrVector<TilingSetEvictionQueue>&
+std::vector<scoped_ptr<TilingSetEvictionQueue>>&
 EvictionTilePriorityQueue::GetNextQueues() {
-  return const_cast<ScopedPtrVector<TilingSetEvictionQueue>&>(
+  return const_cast<std::vector<scoped_ptr<TilingSetEvictionQueue>>&>(

[danakj, 2015/11/17 01:12:18]

The number of casts in this function is approaching infinity.

Would some temp var&s help this be human-parseable?

[vmpstr, 2015/11/17 23:26:24]

Done.

       static_cast<const EvictionTilePriorityQueue*>(this)->GetNextQueues());
 }
 
-const ScopedPtrVector<TilingSetEvictionQueue>&
+const std::vector<scoped_ptr<TilingSetEvictionQueue>>&
 EvictionTilePriorityQueue::GetNextQueues() const {
   DCHECK(!IsEmpty());
 
   // If we only have one queue with tiles, return it.
   if (active_queues_.empty())
     return pending_queues_;
   if (pending_queues_.empty())
     return active_queues_;
 
   const PrioritizedTile& active_tile = active_queues_.front()->Top();
@@ skipping 11 matching lines @@
                                                          : active_queues_;
   }
 
   // Return tile with a lower priority.
   if (pending_priority.IsHigherPriorityThan(active_priority))
     return active_queues_;
   return pending_queues_;
 }
 
 }  // namespace cc