cc: Remove ScopedPtrVector and cc::remove_if.

cc/layers/layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer_impl.h"
 
 #include "base/json/json_reader.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 118 matching lines @@
   DCHECK_EQ(layer_tree_impl(), child->layer_tree_impl());
   children_.push_back(child.Pass());
   layer_tree_impl()->set_needs_update_draw_properties();
 }
 
 scoped_ptr<LayerImpl> LayerImpl::RemoveChild(LayerImpl* child) {
   for (OwnedLayerImplList::iterator it = children_.begin();
        it != children_.end();
        ++it) {
     if (*it == child) {
-      scoped_ptr<LayerImpl> ret = children_.take(it);
+      scoped_ptr<LayerImpl> ret = it->Pass();
       children_.erase(it);
       layer_tree_impl()->set_needs_update_draw_properties();
       return ret.Pass();

[danakj, 2015/11/17 01:12:17]

oops, shame on me

[vmpstr, 2015/11/17 23:26:24]

Done.

     }
   }
   return nullptr;
 }
 
 void LayerImpl::SetParent(LayerImpl* parent) {
   if (parent_should_know_need_push_properties()) {
     if (parent_)
       parent_->RemoveDependentNeedsPushProperties();
     if (parent)
@@ skipping 100 matching lines @@
 void LayerImpl::SetClipTreeIndex(int index) {
   clip_tree_index_ = index;
   SetNeedsPushProperties();
 }
 
 void LayerImpl::SetEffectTreeIndex(int index) {
   effect_tree_index_ = index;
   SetNeedsPushProperties();
 }
 
-void LayerImpl::PassCopyRequests(ScopedPtrVector<CopyOutputRequest>* requests) {
+void LayerImpl::PassCopyRequests(
+    std::vector<scoped_ptr<CopyOutputRequest>>* requests) {
   // In the case that a layer still has a copy request, this means that there's
   // a commit to the active tree without a draw.  This only happens in some
   // edge cases during lost context or visibility changes, so don't try to
   // handle preserving these output requests (and their surface).
   if (!copy_requests_.empty()) {
     layer_tree_impl()->RemoveLayerWithCopyOutputRequest(this);
     // Destroying these will abort them.
     copy_requests_.clear();
   }
 
   if (requests->empty())
     return;
 
   DCHECK(render_surface());
   bool was_empty = copy_requests_.empty();
-  copy_requests_.insert_and_take(copy_requests_.end(), requests);
+  for (auto it = requests->begin(); it != requests->end(); ++it)

[ericrk, 2015/11/16 21:59:49]

not sure if we can use it, but a more C++11-y way to do this is:
copy_requests_.insert(copy_requests_.end(),
std::make_move_iterator(requests->begin()),
std::make_move_iterator(requests->end()));

[danakj, 2015/11/17 01:12:17]

Cool! Someone should propose it to cxx@ now that move() is approved.

In the mean time this could be range-based and auto

[vmpstr, 2015/11/17 23:26:23]

I could do it as 

std::move(requests->begin(), requests->end(),
std::back_inserter(copy_requests_));

but either of those approaches requires extra approval, so I would say it's ok
for now :) WDYT?

[vmpstr, 2015/11/17 23:26:24]

Done.

+    copy_requests_.push_back(it->Pass());
   requests->clear();
 
   if (was_empty && layer_tree_impl()->IsActiveTree())
     layer_tree_impl()->AddLayerWithCopyOutputRequest(this);
   NoteLayerPropertyChangedForSubtree();
 }
 
 void LayerImpl::TakeCopyRequestsAndTransformToTarget(
-    ScopedPtrVector<CopyOutputRequest>* requests) {
+    std::vector<scoped_ptr<CopyOutputRequest>>* requests) {
   DCHECK(!copy_requests_.empty());
   DCHECK(layer_tree_impl()->IsActiveTree());
   DCHECK_EQ(render_target(), this);
 
   size_t first_inserted_request = requests->size();
-  requests->insert_and_take(requests->end(), &copy_requests_);
+  for (auto it = copy_requests_.begin(); it != copy_requests_.end(); ++it)

[ericrk, 2015/11/16 21:59:49]

same here.

+    requests->push_back(it->Pass());
   copy_requests_.clear();
 
   for (size_t i = first_inserted_request; i < requests->size(); ++i) {
-    CopyOutputRequest* request = requests->at(i);
+    CopyOutputRequest* request = (*requests)[i].get();
     if (!request->has_area())
       continue;
 
     gfx::Rect request_in_layer_space = request->area();
     request_in_layer_space.Intersect(gfx::Rect(bounds()));
     request->set_area(MathUtil::MapEnclosingClippedRect(
         draw_properties_.target_space_transform, request_in_layer_space));
   }
 
   layer_tree_impl()->RemoveLayerWithCopyOutputRequest(this);
@@ skipping 1489 matching lines @@
   }
 
   // TODO(enne): the transform needs to come from property trees instead of
   // draw properties.
   gfx::Vector2dF transform_scales = MathUtil::ComputeTransform2dScaleComponents(
       draw_properties().target_space_transform, default_scale);
   return std::max(transform_scales.x(), transform_scales.y());
 }
 
 }  // namespace cc