Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1437383002: Never try to use root to run the mojo tools. (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Never try to use root to run the mojo tools. We instead use run-as to access the stdout fifo file. R=ppi@chromium.org BUG=Fixes https://github.com/domokit/mojo/issues/531 Committed: https://chromium.googlesource.com/external/mojo/+/74043582f211fa2e9e40607927b3e73671dba2c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -60 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 12 chunks +15 lines, -54 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/devtools/common/mojo_test View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
qsr
5 years, 1 month ago (2015-11-13 08:53:05 UTC) #1
ppi
very cool! lgtm
5 years, 1 month ago (2015-11-13 11:04:28 UTC) #2
qsr
5 years, 1 month ago (2015-11-13 12:07:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74043582f211fa2e9e40607927b3e73671dba2c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698