Remove FILE_MANAGER_EXTENSION and related configuration. They can be folded back to Chrome OS as co…

Remove FILE_MANAGER_EXTENSION and related configuration. They can be folded back to Chrome OS as condition.

BUG=166934
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246294

[Junichi Uekawa, 2014-01-21 04:57:27]

Hi,

This is a cleanup to remove "FILE_MANAGER_EXTENSION" which could not be set
independently from OS_CHROMEOS.

yoz: extensions/ 
thestig: the rest

[Lei Zhang, 2014-01-21 20:38:01]

lgtm

https://codereview.chromium.org/143733002/diff/100001/chrome/browser/translat...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/143733002/diff/100001/chrome/browser/translat...
chrome/browser/translate/translate_manager.cc:57: #ifdef OS_CHROMEOS
Change this to #id defined(OS_CHROMEOS) while you are at it? Ditto below and in
translate_manager_unittest.cc.

https://codereview.chromium.org/143733002/diff/100001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/143733002/diff/100001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:1792: ['chromeos==0', {
combine this block with the chromeos==0 block on line 1759?

[Yoyo Zhou, 2014-01-22 00:09:00]

LGTM with nits (as suggested by Lei)
Also it looks like some combining is possible in the .grd files, but since there
is no such prevailing style there, I think they're fine as is.

[Junichi Uekawa, 2014-01-22 01:11:35]

Thanks for the review.

https://codereview.chromium.org/143733002/diff/100001/chrome/browser/translat...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/143733002/diff/100001/chrome/browser/translat...
chrome/browser/translate/translate_manager.cc:57: #ifdef OS_CHROMEOS
On 2014/01/21 20:38:01, Lei Zhang wrote:
> Change this to #id defined(OS_CHROMEOS) while you are at it? Ditto below and
in
> translate_manager_unittest.cc.

Done.

https://codereview.chromium.org/143733002/diff/100001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/143733002/diff/100001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:1792: ['chromeos==0', {
On 2014/01/21 20:38:01, Lei Zhang wrote:
> combine this block with the chromeos==0 block on line 1759?

Done.

[commit-bot: I haz the power, 2014-01-22 01:28:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/uekawa@chromium.org/143733002/240001

[commit-bot: I haz the power, 2014-01-22 02:56:18]

Retried try job too often on linux_rel for step(s) browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chromedriver_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, google_apis_unittests, gpu_unittests,
ipc_tests, jingle_unittests, media_unittests, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sandbox_linux_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-22 04:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/uekawa@chromium.org/143733002/240001

[commit-bot: I haz the power, 2014-01-22 11:09:34]

Change committed as 246294