Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1437303002: Allow goma to work w/ NaCl toolchains in GN build. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
Roland McGrath
CC:
chromium-reviews, brettw, sehr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow goma to work w/ NaCl toolchains in GN build. This change allows the default logic for goma to work for NaCl (which appears to work fine, at least in local testing, and it looks like build_nexe.py supports goma these days as well). Let's enable this and see what happens; if this doesn't work, then we need to figure out a way to set a per-toolchain limit on concurrent compiles like there is for concurrent_links , and figure out how to make that get set appropriately for nacl differently from cc. R=mcgrathr@chromium.org BUG=555123 Committed: https://crrev.com/d434bf3f1b28416a88604325372a01b908c099c0 Cr-Commit-Position: refs/heads/master@{#359595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/toolchain/nacl_toolchain.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
5 years, 1 month ago (2015-11-12 23:23:45 UTC) #1
Roland McGrath
lgtm
5 years, 1 month ago (2015-11-13 18:01:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437303002/1
5 years, 1 month ago (2015-11-13 18:02:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/136078)
5 years, 1 month ago (2015-11-13 18:11:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437303002/1
5 years, 1 month ago (2015-11-13 18:44:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 19:17:47 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 19:18:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d434bf3f1b28416a88604325372a01b908c099c0
Cr-Commit-Position: refs/heads/master@{#359595}

Powered by Google App Engine
This is Rietveld 408576698