Issue 14373016: DevTools: [HeapProfiler] Provide API for heap objects tracking info.

Issue 14373016: DevTools: [HeapProfiler] Provide API for heap objects tracking info. (Closed)

Created:
7 years, 8 months ago by loislo

Modified:
7 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), yurys, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, aandrey+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [HeapProfiler] Provide API for heap objects tracking info. We can track changes in the v8 heap. With these data we will be able to map a time range to the heap object ids range. As a result we could draw a time range selector for heap snapshot and event support a live view for v8 heap changes. BUG=none TEST=none R= pfeldman@chromium.org, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149106

Patch Set 1 #

Patch Set 2 : description was slightly changed #

Total comments: 10

Patch Set 3 : comments addressed #

Patch Set 4 : reupload #

Total comments: 1

Patch Set 5 : jank -> junk #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+280 lines, -11 lines)			Patch
M	LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html	View	1 2 3 4	1 chunk	+76 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking-expected.txt	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html	View	1 2	3 chunks	+5 lines, -10 lines	0 comments	Download
M	LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptProfiler.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptProfiler.cpp	View	1 2	2 chunks	+49 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.h	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.cpp	View	1 2	4 chunks	+88 lines, -0 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

yurys

not lgtm, please add a protocol test for the new functionality. https://codereview.chromium.org/14373016/diff/1006/Source/bindings/v8/ScriptProfiler.cpp File Source/bindings/v8/ScriptProfiler.cpp (right): ...

7 years, 8 months ago (2013-04-25 12:23:15 UTC) #4

loislo

comments addressed https://codereview.chromium.org/14373016/diff/1006/Source/bindings/v8/ScriptProfiler.cpp File Source/bindings/v8/ScriptProfiler.cpp (right): https://codereview.chromium.org/14373016/diff/1006/Source/bindings/v8/ScriptProfiler.cpp#newcode230 Source/bindings/v8/ScriptProfiler.cpp:230: m_stream->write(rawData.data(), count * 3); On 2013/04/25 12:23:15, ...

7 years, 8 months ago (2013-04-25 13:33:56 UTC) #5

yurys

lgtm https://codereview.chromium.org/14373016/diff/6004/LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html File LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html (right): https://codereview.chromium.org/14373016/diff/6004/LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html#newcode11 LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html:11: function jankGenerator() jank -> junk

7 years, 8 months ago (2013-04-25 14:08:25 UTC) #7

loislo

7 years, 8 months ago (2013-04-25 14:17:41 UTC) #9

Message was sent while issue was closed.

Committed patchset #5 manually as r149106 (presubmit successful).

Expand Messages | Collapse Messages