LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Unified Diff: LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-scrolled-viewport-expected.html ('k') | LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block-expected.html » ('j') | Source/core/html/HTMLDialogElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html

diff --git a/LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html b/LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html

index 5e8e9d619d088a83cc3cb1d6c20978df2b7ee089..87f064952965a5e01619bee4af99a22b14fc9138 100644

--- a/LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html

+++ b/LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block.html

@@ -8,29 +8,21 @@ if (window.internals)

</head>

<body>

<p>

-This tests that a top layer element's containing block is in the initial containing block and that it is unaffected by

-ancestor elements with overflow or opacity. Dialog elements are used to demonstrate these properties. A dialog opened

-with showModal() is in the top layer; one opened with dialog.show() is not.

+This tests that a modal dialog's containing block is in the initial containing block and that it is unaffected by

+ancestor elements with overflow or opacity.

- This modal dialog should be unaffected by its ancestor with opacity.

- </dialog>

- <dialog id="translucentDialog" style="position: absolute; top: 0px; height: 150px; width: 150px; background-color: magenta">

- This non-modal dialog should be affected by its ancestor with opacity.

+ This dialog should be unaffected by its ancestor with opacity.

</dialog>

</div>

- This modal dialog should be unaffected by its ancestor with overflow. It should not be clipped.

- </dialog>

- <dialog id="clippedDialog" style="position: absolute; top: 0px; height: 150px; width: 150px; background-color: cyan">

- This non-modal dialog should be affected by its ancestor with overflow. It should be clipped.

+ This dialog should be unaffected by its ancestor with overflow. It should not be clipped.

</dialog>

</div>

- This modal dialog should be onscreen with a width of 90% of the page. It is the child of an narrow element

+ This dialog should be onscreen with a width of 90% of the page. It is the child of an narrow element

positioned off screen, but the containing block of a top layer element is the initial containing block, so its

position and percent lengths are relative to that.

</dialog>

@@ -39,8 +31,6 @@ with showModal() is in the top layer; one opened with dialog.show() is not.

document.getElementById('bottomDialog').showModal();

document.getElementById('unclippedDialog').showModal();

document.getElementById('opaqueDialog').showModal();

-document.getElementById('clippedDialog').show();

-document.getElementById('translucentDialog').show();

</script>

</body>

</html>