LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html ('k') | LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-containing-block.html » ('j') | Source/core/html/HTMLDialogElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt

diff --git a/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt b/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt

index 3570259b50f2ab34ef651171aafc2ec84591957c..6c2d40ab03254e107e87dbee895e0a9ed975eacd 100644

--- a/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt

+++ b/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt

@@ -1,4 +1,4 @@

-Tests default positioning of non-anchored dialogs.

+Tests positioning of non-anchored dialogs.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

@@ -42,22 +42,22 @@ Dialog should not be centered if show() was called when an ancestor had display

PASS dialog.getBoundingClientRect().top is expectedTop

Test that setting 'top' on dialog results in the same position as for a plain, absolutely positioned span.

-PASS dialog.offsetTop is plainSpan.offsetTop

+PASS dialog.getBoundingClientRect().top is expectedTop

Test that setting 'bottom' on dialog results in the same position as for a plain, absolutely positioned span.

-PASS dialog.offsetBottom is plainSpan.offsetBottom

+PASS dialog.getBoundingClientRect().bottom is plainSpan.getBoundingClientRect().bottom

Test that fixed positioning for dialog has same behavior as for a plain span.

-PASS dialog.offsetTop is plainSpan.offsetTop

+PASS dialog.getBoundingClientRect().top is plainSpan.getBoundingClientRect().top

Test that static position for a non-modal dialog has the same behavior as for a plain span.

-PASS dialog.offsetTop is expectedTop

+PASS dialog.getBoundingClientRect().top is expectedTop

Test that relative position for a non-modal dialog has the same behavior as for a plain span.

-PASS dialog.offsetTop is expectedTop

+PASS dialog.getBoundingClientRect().top is expectedTop

PASS successfullyParsed is true

TEST COMPLETE