Source/core/dom/Element.h - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index bb7c9eabd1c0cb68b2850f0abf782706237ff3c6..60b634f563c1e9a25db9c9db5cec8e599176e55f 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -554,6 +554,7 @@ public:

virtual bool isDisabledFormControl() const;

bool isInert() const;

+ virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const { return isInTopLayer(); }

#if ENABLE(SVG)

virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const;