LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block-scrolled-viewport.html - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block-scrolled-viewport.html

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block-expected.html ('k') | LayoutTests/fast/dom/HTMLDialogElement/top-layer-containing-block-scrolled-viewport-expected.html » ('j') | Source/core/dom/NodeRenderingContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.internals)

	6 internals.settings.setDialogElementEnabled(true);

	7 </script>

	8 </head>

	9 <body style="height: 10000px; width: 10000px">

	10 <p style="position: fixed">

	11 This tests that a top layer element's containing block is the initial containing

	12 block. The dialog is positioned at (1200, 1200) and the window is scrolled to

	13 (1000, 1000) so the dialog should be positioned at (200, 200) relative to the

	14 viewport.
	Julien - ping for review 2013/05/09 18:46:58 Nit: If you only want to check the scroll offset o Nit: If you only want to check the scroll offset or position, it seems that a ref-test is an overkill and you could get away with a checkLayout test (or even just a plain manual one). falken 2013/05/10 05:50:25 Oh, I wasn't aware of checkLayout. I think I'll le Show quoted text On 2013/05/09 18:46:58, Julien Chaffraix wrote: > Nit: If you only want to check the scroll offset or position, it seems that a > ref-test is an overkill and you could get away with a checkLayout test (or even > just a plain manual one). Oh, I wasn't aware of checkLayout. I think I'll leave these ones for now, and keep it in mind for future tests.
	15 </p>

	16 <div style="position: absolute; top: 5000px; left: 5000px; width: 20px;">

	17 <dialog id="dialog" style="top: 1200px; left: 1200px; right: auto; height: 2 50px; width: 50%; background-color: yellow">

	18 This dialog should be onscreen with a width of 50% of the viewport. It i s the child of an narrow element

	19 positioned off screen, but its containing block is the initial containin g block, so its

	20 position and percent lengths are relative to that.

	21 </dialog>

	22 </div>

	23 <script>

	24 window.scroll(1000, 1000);

	25 document.getElementById('dialog').showModal();

	26 </script>

	27 </body>

	28 </html>

OLD	NEW