Source/core/html/HTMLDialogElement.h - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLDialogElement.h

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 28 matching lines...) Expand all Loading...
39	39

40 void close(ExceptionCode&);	40 void close(ExceptionCode&);

41 void show();	41 void show();

42 void showModal(ExceptionCode&);	42 void showModal(ExceptionCode&);

43	43

44 private:	44 private:

45 HTMLDialogElement(const QualifiedName&, Document*);	45 HTMLDialogElement(const QualifiedName&, Document*);

46	46

47 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;	47 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;

48 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;	48 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;

	49 virtual bool isReparentedByRenderView(const RenderStyle*) const OVERRIDE;
	Julien - ping for review 2013/05/01 23:35:48 Not a huge fan of the naming here. How about shoul Not a huge fan of the naming here. How about shouldBeReparentedUnderRenderView? falken 2013/05/02 13:11:59 Sounds OK to me. Show quoted text On 2013/05/01 23:35:48, Julien Chaffraix wrote: > Not a huge fan of the naming here. How about shouldBeReparentedUnderRenderView? Sounds OK to me. falken 2013/05/08 08:13:29 Done. Show quoted text On 2013/05/02 13:11:59, falken wrote: > On 2013/05/01 23:35:48, Julien Chaffraix wrote: > > Not a huge fan of the naming here. How about > shouldBeReparentedUnderRenderView? > > Sounds OK to me. Done.
49 void positionAndReattach();	50 void positionAndReattach();

50	51

51 bool m_topIsValid;	52 bool m_topIsValid;

52 LayoutUnit m_top;	53 LayoutUnit m_top;

53 };	54 };

54	55

55 } // namespace WebCore	56 } // namespace WebCore

56	57

57 #endif	58 #endif

OLD	NEW

« Source/core/dom/NodeRenderingContext.cpp ('K') | « Source/core/dom/NodeRenderingContext.cpp ('k') | Source/core/html/HTMLDialogElement.cpp » ('j') | no next file with comments »