LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-containing-block.html - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-containing-block.html

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt ('k') | LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-containing-block-expected.html » ('j') | Source/core/dom/NodeRenderingContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.internals)

	6 internals.settings.setDialogElementEnabled(true);

	7 </script>

	8 </head>

	9 <body>

	10 <p>

	11 This tests that a dialog's containing block is in the initial containing block a nd that it is unaffected by

	12 ancestor elements with overflow or opacity.

	13 <div style="position: absolute; top: 400px; opacity: 0.3">

	14 <dialog id="opaqueDialog" style="position: absolute; top: 250px; left: 0px; background-color: magenta">

	15 This dialog should be unaffected by its ancestor with opacity.

	16 </dialog>

	17 </div>

	18 <div style="position: absolute; overflow: hidden; width: 500px; height: 150px; t op: 400px; left: 300px">

	19 <dialog id="unclippedDialog" style="position: absolute; top: 200px; left: 0p x; height: 100px; background-color: cyan">

	20 This dialog should be unaffected by its ancestor with overflow. It shoul d not be clipped.

	21 </dialog>

	22 </div>

	23 <div style="position: absolute; top: 1000px; left: 1000px; width: 20px;">

	24 <dialog id="bottomDialog" style="position: absolute; top: 100px; height: 250 px; width: 90%; background-color: yellow">

	25 This dialog should be onscreen with a width of 90% of the page. It is th e child of an narrow element

	26 positioned off screen, but the containing block of a top layer element i s the initial containing block, so its

	27 position and percent lengths are relative to that.

	28 </dialog>

	29 </div>

	30 <script>

	31 document.getElementById('bottomDialog').show();

	32 document.getElementById('unclippedDialog').show();

	33 document.getElementById('opaqueDialog').show();

	34 </script>

	35 </body>

	36 </html>
	Julien - ping for review 2013/05/01 23:35:48 Do we have testing for a scrolled viewport? (would Do we have testing for a scrolled viewport? (would be nice to have it) falken 2013/05/02 13:11:59 I'll see if I can add this. Show quoted text On 2013/05/01 23:35:48, Julien Chaffraix wrote: > Do we have testing for a scrolled viewport? (would be nice to have it) I'll see if I can add this. falken 2013/05/08 08:13:29 Done. Show quoted text On 2013/05/02 13:11:59, falken wrote: > On 2013/05/01 23:35:48, Julien Chaffraix wrote: > > Do we have testing for a scrolled viewport? (would be nice to have it) > > I'll see if I can add this. Done.
OLD	NEW