Issue 14373008: Web MIDI: clean up on MIDIPort and MIDIErrorCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14373008: Web MIDI: clean up on MIDIPort and MIDIErrorCallback (Closed)

Created:
7 years, 8 months ago by Takashi Toyoshima

Modified:
7 years, 8 months ago

Reviewers:
tkent, Chris Rogers

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Web MIDI: clean up on MIDIPort and MIDIErrorCallback - Style fix on include statements - MIDIPortType should be readonly enum because it's available now BUG=163795 TEST=none R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149161

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
M	Source/modules/webmidi/MIDIErrorCallback.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/webmidi/MIDIPort.cpp	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/modules/webmidi/MIDIPort.idl	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Takashi Toyoshima

Oops, maybe I miss to publish this change. Could you guys take a look this ...

7 years, 8 months ago (2013-04-26 02:52:53 UTC) #1

Takashi Toyoshima

7 years, 8 months ago (2013-04-26 05:03:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r149161 (presubmit successful).