Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5053)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1437283003: [DevTools] filter any messages from previous session in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/html_viewer/devtools_agent_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 41863af5b69883153a826134e32132da0dd64d0c..5344e244fdbb73a9f0699e85a6ca4671e0bc1b46 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -520,7 +520,6 @@ void DevToolsWindow::InspectElement(
int y) {
scoped_refptr<DevToolsAgentHost> agent(
DevToolsAgentHost::GetOrCreateFor(inspected_frame_host));
- agent->InspectElement(x, y);
bool should_measure_time = FindDevToolsWindow(agent.get()) == NULL;
base::TimeTicks start_time = base::TimeTicks::Now();
// TODO(loislo): we should initiate DevTools window opening from within
@@ -532,6 +531,8 @@ void DevToolsWindow::InspectElement(
agent);
}
+ agent->InspectElement(x, y);
pfeldman 2015/11/13 17:38:12 Lets land this separately.
+
DevToolsWindow* window = FindDevToolsWindow(agent.get());
if (should_measure_time && window)
window->inspect_element_start_time_ = start_time;
« no previous file with comments | « no previous file | components/html_viewer/devtools_agent_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698