Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1437173002: Target Mac bots at 10.7+libc++ to approximate Chrome's 10.6+libc++. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Target Mac bots at 10.7+libc++ to approximate Chrome's 10.6+libc++. This is necessary if we want to start using C++11 library features. Chrome's got their own custom libc++-for-10.6. This is a somewhat lazy approximation of that. Chrome should still guard us from using 10.7-specific features until 10.6-10.8 all go away. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d7b25c734e6835152451fbe2ff3b809c5006ad51

Patch Set 1 #

Patch Set 2 : skdiff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
5 years, 1 month ago (2015-11-12 15:42:30 UTC) #2
mtklein_C
Er, one more time.
5 years, 1 month ago (2015-11-12 15:42:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437173002/1
5 years, 1 month ago (2015-11-12 15:42:56 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-12 15:43:00 UTC) #7
bungeman-skia
If we're going to do this, let's also remove the precursor to this from gyp/tools#skdiff ...
5 years, 1 month ago (2015-11-12 15:54:47 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437173002/20001
5 years, 1 month ago (2015-11-12 16:30:40 UTC) #10
bungeman-skia
lgtm
5 years, 1 month ago (2015-11-12 16:31:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437173002/20001
5 years, 1 month ago (2015-11-12 16:32:44 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 16:41:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d7b25c734e6835152451fbe2ff3b809c5006ad51

Powered by Google App Engine
This is Rietveld 408576698