Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1437133002: Componentize the GCM info collection for gcm-internals. (Closed)

Created:
5 years, 1 month ago by droger
Modified:
5 years, 1 month ago
Reviewers:
Nicolas Zea, Dan Beam
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize the GCM info collection for gcm-internals. This CL componentizes the function GcmInternalsUIMessageHandler::ReturnResults and the related code, so that it can be shared on iOS. TBR=dbeam Committed: https://crrev.com/08025a2c7d461694d57d1a83661fb5cfb9790bcd Cr-Commit-Position: refs/heads/master@{#359814}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -383 lines) Patch
M chrome/browser/ui/webui/gcm_internals_ui.cc View 4 chunks +3 lines, -143 lines 0 comments Download
M components/gcm_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/gcm_driver/gcm_internals_helper.h View 1 chunk +22 lines, -11 lines 0 comments Download
A + components/gcm_driver/gcm_internals_helper.cc View 1 chunk +66 lines, -229 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
droger
5 years, 1 month ago (2015-11-12 14:16:17 UTC) #6
Nicolas Zea
lgtm
5 years, 1 month ago (2015-11-13 22:25:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437133002/60001
5 years, 1 month ago (2015-11-16 09:49:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/118816)
5 years, 1 month ago (2015-11-16 09:57:56 UTC) #11
droger
TBR=dbeam for changes chrome/browser/ui/webui/gcm_internals (deleted code).
5 years, 1 month ago (2015-11-16 10:04:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437133002/60001
5 years, 1 month ago (2015-11-16 10:05:42 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 1 month ago (2015-11-16 10:58:59 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08025a2c7d461694d57d1a83661fb5cfb9790bcd Cr-Commit-Position: refs/heads/master@{#359814}
5 years, 1 month ago (2015-11-16 10:59:47 UTC) #18
Dan Beam
5 years, 1 month ago (2015-11-18 05:33:44 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698