Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: media/base/pipeline.h

Issue 14371023: Remove reference counting from media::Pipeline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/pipeline.cc » ('j') | webkit/media/webmediaplayer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 34e36f0ad2d4ee4bda3445b76b760b260b7f352b..ec495ccfc4902ea6b124f31428eee6fe10123906 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -90,9 +90,7 @@ class MEDIA_EXPORT PipelineStatusNotification {
// If any error ever happens, this object will transition to the "Error" state
// from any state. If Stop() is ever called, this object will transition to
// "Stopped" state.
-class MEDIA_EXPORT Pipeline
- : public base::RefCountedThreadSafe<Pipeline>,
- public DemuxerHost {
+class MEDIA_EXPORT Pipeline : public DemuxerHost {
public:
// Buffering states the pipeline transitions between during playback.
// kHaveMetadata:
@@ -112,6 +110,7 @@ class MEDIA_EXPORT Pipeline
// Constructs a media pipeline that will execute on |message_loop|.
Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
MediaLog* media_log);
+ virtual ~Pipeline();
// Build a pipeline to using the given filter collection to construct a filter
// chain, executing |seek_cb| when the initial seek/preroll has completed.
@@ -225,10 +224,6 @@ class MEDIA_EXPORT Pipeline
FRIEND_TEST_ALL_PREFIXES(PipelineTest, AudioStreamShorterThanVideo);
friend class MediaLog;
- // Only allow ourselves to be deleted by reference counting.
- friend class base::RefCountedThreadSafe<Pipeline>;
- virtual ~Pipeline();
-
// Pipeline states, as described above.
enum State {
kCreated,
« no previous file with comments | « no previous file | media/base/pipeline.cc » ('j') | webkit/media/webmediaplayer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698