Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14371011: path ops : add support for inverse fill (Closed)

Created:
7 years, 8 months ago by caryclark
Modified:
7 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

path ops : add support for inverse fill add inverse fill, reverse diff, and gm tests cleaned up some interfaces Committed: https://code.google.com/p/skia/source/detail?r=8798

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -17 lines) Patch
A gm/pathopsinverse.cpp View 1 chunk +116 lines, -0 lines 2 comments Download
M gyp/gmslides.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M gyp/pathops_unittest.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/pathops/SkPathOps.h View 1 chunk +9 lines, -9 lines 1 comment Download
M src/pathops/SkOpSegment.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 2 chunks +35 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
A tests/PathOpsInverseTest.cpp View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
Brian, this is my first GM -- please take a look to see if I'm ...
7 years, 8 months ago (2013-04-22 12:51:47 UTC) #1
bsalomon
LGTM w/ some inline comments. https://codereview.chromium.org/14371011/diff/1/gm/pathopsinverse.cpp File gm/pathopsinverse.cpp (right): https://codereview.chromium.org/14371011/diff/1/gm/pathopsinverse.cpp#newcode19 gm/pathopsinverse.cpp:19: this->makePaints(); There's a virtual ...
7 years, 8 months ago (2013-04-22 13:13:57 UTC) #2
caryclark
7 years, 8 months ago (2013-04-22 14:37:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698