src/arm/lithium-arm.cc - Issue 14371005: Various improvements regarding the way we print code code comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-arm.cc

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-arm.cc

diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc

index 618ac102459b40ecab513589670ec1c737341f70..b240de7f11dc8d88bf09467090e2cf8a95130056 100644

--- a/src/arm/lithium-arm.cc

+++ b/src/arm/lithium-arm.cc

@@ -192,6 +192,11 @@ const char* LArithmeticT::Mnemonic() const {

}

+bool LGoto::HasInterestingComment(LCodeGen* gen) const {

+ return !gen->IsNextEmittedBlock(block_id());

void LGoto::PrintDataTo(StringStream* stream) {

stream->Add("B%d", block_id());

}

« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.h » ('j') | no next file with comments »