Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/lithium-codegen-x64.h

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 } 73 }
74 74
75 // Simple accessors. 75 // Simple accessors.
76 MacroAssembler* masm() const { return masm_; } 76 MacroAssembler* masm() const { return masm_; }
77 CompilationInfo* info() const { return info_; } 77 CompilationInfo* info() const { return info_; }
78 Isolate* isolate() const { return info_->isolate(); } 78 Isolate* isolate() const { return info_->isolate(); }
79 Factory* factory() const { return isolate()->factory(); } 79 Factory* factory() const { return isolate()->factory(); }
80 Heap* heap() const { return isolate()->heap(); } 80 Heap* heap() const { return isolate()->heap(); }
81 Zone* zone() const { return zone_; } 81 Zone* zone() const { return zone_; }
82 82
83 // TODO(svenpanne) Use this consistently.
84 int LookupDestination(int block_id) const {
85 return chunk()->LookupDestination(block_id);
86 }
87
88 bool IsNextEmittedBlock(int block_id) const {
89 return LookupDestination(block_id) == GetNextEmittedBlock();
90 }
91
83 bool NeedsEagerFrame() const { 92 bool NeedsEagerFrame() const {
84 return GetStackSlotCount() > 0 || 93 return GetStackSlotCount() > 0 ||
85 info()->is_non_deferred_calling() || 94 info()->is_non_deferred_calling() ||
86 !info()->IsStub() || 95 !info()->IsStub() ||
87 info()->requires_frame(); 96 info()->requires_frame();
88 } 97 }
89 bool NeedsDeferredFrame() const { 98 bool NeedsDeferredFrame() const {
90 return !NeedsEagerFrame() && info()->is_deferred_calling(); 99 return !NeedsEagerFrame() && info()->is_deferred_calling();
91 } 100 }
92 101
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 bool is_generating() const { return status_ == GENERATING; } 162 bool is_generating() const { return status_ == GENERATING; }
154 bool is_done() const { return status_ == DONE; } 163 bool is_done() const { return status_ == DONE; }
155 bool is_aborted() const { return status_ == ABORTED; } 164 bool is_aborted() const { return status_ == ABORTED; }
156 165
157 StrictModeFlag strict_mode_flag() const { 166 StrictModeFlag strict_mode_flag() const {
158 return info()->is_classic_mode() ? kNonStrictMode : kStrictMode; 167 return info()->is_classic_mode() ? kNonStrictMode : kStrictMode;
159 } 168 }
160 169
161 LPlatformChunk* chunk() const { return chunk_; } 170 LPlatformChunk* chunk() const { return chunk_; }
162 Scope* scope() const { return scope_; } 171 Scope* scope() const { return scope_; }
163 HGraph* graph() const { return chunk_->graph(); } 172 HGraph* graph() const { return chunk()->graph(); }
164 173
165 int GetNextEmittedBlock(); 174 int GetNextEmittedBlock() const;
166 175
167 void EmitClassOfTest(Label* if_true, 176 void EmitClassOfTest(Label* if_true,
168 Label* if_false, 177 Label* if_false,
169 Handle<String> class_name, 178 Handle<String> class_name,
170 Register input, 179 Register input,
171 Register temporary, 180 Register temporary,
172 Register scratch); 181 Register scratch);
173 182
174 int GetStackSlotCount() const { return chunk()->spill_slot_count(); } 183 int GetStackSlotCount() const { return chunk()->spill_slot_count(); }
175 184
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 LCodeGen* codegen_; 441 LCodeGen* codegen_;
433 Label entry_; 442 Label entry_;
434 Label exit_; 443 Label exit_;
435 Label* external_exit_; 444 Label* external_exit_;
436 int instruction_index_; 445 int instruction_index_;
437 }; 446 };
438 447
439 } } // namespace v8::internal 448 } } // namespace v8::internal
440 449
441 #endif // V8_X64_LITHIUM_CODEGEN_X64_H_ 450 #endif // V8_X64_LITHIUM_CODEGEN_X64_H_
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698