Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 case Token::SHL: return "sll-t"; 185 case Token::SHL: return "sll-t";
186 case Token::SAR: return "sra-t"; 186 case Token::SAR: return "sra-t";
187 case Token::SHR: return "srl-t"; 187 case Token::SHR: return "srl-t";
188 default: 188 default:
189 UNREACHABLE(); 189 UNREACHABLE();
190 return NULL; 190 return NULL;
191 } 191 }
192 } 192 }
193 193
194 194
195 bool LGoto::HasInterestingComment(LCodeGen* gen) const {
196 return !gen->IsNextEmittedBlock(block_id());
197 }
198
199
195 void LGoto::PrintDataTo(StringStream* stream) { 200 void LGoto::PrintDataTo(StringStream* stream) {
196 stream->Add("B%d", block_id()); 201 stream->Add("B%d", block_id());
197 } 202 }
198 203
199 204
200 void LBranch::PrintDataTo(StringStream* stream) { 205 void LBranch::PrintDataTo(StringStream* stream) {
201 stream->Add("B%d | B%d on ", true_block_id(), false_block_id()); 206 stream->Add("B%d | B%d on ", true_block_id(), false_block_id());
202 value()->PrintTo(stream); 207 value()->PrintTo(stream);
203 } 208 }
204 209
(...skipping 2271 matching lines...) Expand 10 before | Expand all | Expand 10 after
2476 2481
2477 2482
2478 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2483 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2479 LOperand* object = UseRegister(instr->object()); 2484 LOperand* object = UseRegister(instr->object());
2480 LOperand* index = UseRegister(instr->index()); 2485 LOperand* index = UseRegister(instr->index());
2481 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2486 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2482 } 2487 }
2483 2488
2484 2489
2485 } } // namespace v8::internal 2490 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698