Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: src/mips/lithium-codegen-mips.h

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lithium.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 73
74 // Simple accessors. 74 // Simple accessors.
75 MacroAssembler* masm() const { return masm_; } 75 MacroAssembler* masm() const { return masm_; }
76 CompilationInfo* info() const { return info_; } 76 CompilationInfo* info() const { return info_; }
77 Isolate* isolate() const { return info_->isolate(); } 77 Isolate* isolate() const { return info_->isolate(); }
78 Factory* factory() const { return isolate()->factory(); } 78 Factory* factory() const { return isolate()->factory(); }
79 Heap* heap() const { return isolate()->heap(); } 79 Heap* heap() const { return isolate()->heap(); }
80 Zone* zone() const { return zone_; } 80 Zone* zone() const { return zone_; }
81 81
82 // TODO(svenpanne) Use this consistently.
83 int LookupDestination(int block_id) const {
84 return chunk()->LookupDestination(block_id);
85 }
86
87 bool IsNextEmittedBlock(int block_id) const {
88 return LookupDestination(block_id) == GetNextEmittedBlock();
89 }
90
82 bool NeedsEagerFrame() const { 91 bool NeedsEagerFrame() const {
83 return GetStackSlotCount() > 0 || 92 return GetStackSlotCount() > 0 ||
84 info()->is_non_deferred_calling() || 93 info()->is_non_deferred_calling() ||
85 !info()->IsStub() || 94 !info()->IsStub() ||
86 info()->requires_frame(); 95 info()->requires_frame();
87 } 96 }
88 bool NeedsDeferredFrame() const { 97 bool NeedsDeferredFrame() const {
89 return !NeedsEagerFrame() && info()->is_deferred_calling(); 98 return !NeedsEagerFrame() && info()->is_deferred_calling();
90 } 99 }
91 100
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 bool is_generating() const { return status_ == GENERATING; } 192 bool is_generating() const { return status_ == GENERATING; }
184 bool is_done() const { return status_ == DONE; } 193 bool is_done() const { return status_ == DONE; }
185 bool is_aborted() const { return status_ == ABORTED; } 194 bool is_aborted() const { return status_ == ABORTED; }
186 195
187 StrictModeFlag strict_mode_flag() const { 196 StrictModeFlag strict_mode_flag() const {
188 return info()->is_classic_mode() ? kNonStrictMode : kStrictMode; 197 return info()->is_classic_mode() ? kNonStrictMode : kStrictMode;
189 } 198 }
190 199
191 LPlatformChunk* chunk() const { return chunk_; } 200 LPlatformChunk* chunk() const { return chunk_; }
192 Scope* scope() const { return scope_; } 201 Scope* scope() const { return scope_; }
193 HGraph* graph() const { return chunk_->graph(); } 202 HGraph* graph() const { return chunk()->graph(); }
194 203
195 Register scratch0() { return kLithiumScratchReg; } 204 Register scratch0() { return kLithiumScratchReg; }
196 Register scratch1() { return kLithiumScratchReg2; } 205 Register scratch1() { return kLithiumScratchReg2; }
197 DoubleRegister double_scratch0() { return kLithiumScratchDouble; } 206 DoubleRegister double_scratch0() { return kLithiumScratchDouble; }
198 207
199 int GetNextEmittedBlock(); 208 int GetNextEmittedBlock() const;
200 LInstruction* GetNextInstruction(); 209 LInstruction* GetNextInstruction();
201 210
202 void EmitClassOfTest(Label* if_true, 211 void EmitClassOfTest(Label* if_true,
203 Label* if_false, 212 Label* if_false,
204 Handle<String> class_name, 213 Handle<String> class_name,
205 Register input, 214 Register input,
206 Register temporary, 215 Register temporary,
207 Register temporary2); 216 Register temporary2);
208 217
209 int GetStackSlotCount() const { return chunk()->spill_slot_count(); } 218 int GetStackSlotCount() const { return chunk()->spill_slot_count(); }
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 LCodeGen* codegen_; 507 LCodeGen* codegen_;
499 Label entry_; 508 Label entry_;
500 Label exit_; 509 Label exit_;
501 Label* external_exit_; 510 Label* external_exit_;
502 int instruction_index_; 511 int instruction_index_;
503 }; 512 };
504 513
505 } } // namespace v8::internal 514 } } // namespace v8::internal
506 515
507 #endif // V8_MIPS_LITHIUM_CODEGEN_MIPS_H_ 516 #endif // V8_MIPS_LITHIUM_CODEGEN_MIPS_H_
OLDNEW
« no previous file with comments | « src/lithium.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698