Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/lithium.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 case Token::SHL: return "sal-t"; 203 case Token::SHL: return "sal-t";
204 case Token::SAR: return "sar-t"; 204 case Token::SAR: return "sar-t";
205 case Token::SHR: return "shr-t"; 205 case Token::SHR: return "shr-t";
206 default: 206 default:
207 UNREACHABLE(); 207 UNREACHABLE();
208 return NULL; 208 return NULL;
209 } 209 }
210 } 210 }
211 211
212 212
213 bool LGoto::HasInterestingComment(LCodeGen* gen) const {
214 return !gen->IsNextEmittedBlock(block_id());
215 }
216
217
213 void LGoto::PrintDataTo(StringStream* stream) { 218 void LGoto::PrintDataTo(StringStream* stream) {
214 stream->Add("B%d", block_id()); 219 stream->Add("B%d", block_id());
215 } 220 }
216 221
217 222
218 void LBranch::PrintDataTo(StringStream* stream) { 223 void LBranch::PrintDataTo(StringStream* stream) {
219 stream->Add("B%d | B%d on ", true_block_id(), false_block_id()); 224 stream->Add("B%d | B%d on ", true_block_id(), false_block_id());
220 value()->PrintTo(stream); 225 value()->PrintTo(stream);
221 } 226 }
222 227
(...skipping 2530 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2758 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2754 LOperand* object = UseRegister(instr->object()); 2759 LOperand* object = UseRegister(instr->object());
2755 LOperand* index = UseTempRegister(instr->index()); 2760 LOperand* index = UseTempRegister(instr->index());
2756 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2761 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2757 } 2762 }
2758 2763
2759 2764
2760 } } // namespace v8::internal 2765 } } // namespace v8::internal
2761 2766
2762 #endif // V8_TARGET_ARCH_IA32 2767 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/lithium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698