Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 14371005: Various improvements regarding the way we print code code comments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/ia32/lithium-ia32.cc ('K') | « src/x64/lithium-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 case Token::SHL: return "sal-t"; 187 case Token::SHL: return "sal-t";
188 case Token::SAR: return "sar-t"; 188 case Token::SAR: return "sar-t";
189 case Token::SHR: return "shr-t"; 189 case Token::SHR: return "shr-t";
190 default: 190 default:
191 UNREACHABLE(); 191 UNREACHABLE();
192 return NULL; 192 return NULL;
193 } 193 }
194 } 194 }
195 195
196 196
197 bool LGoto::HasInterestingComment(LCodeGen* gen) const {
198 return !gen->IsNextEmittedBlock(block_id());
199 }
200
201
197 void LGoto::PrintDataTo(StringStream* stream) { 202 void LGoto::PrintDataTo(StringStream* stream) {
198 stream->Add("B%d", block_id()); 203 stream->Add("B%d", block_id());
199 } 204 }
200 205
201 206
202 void LBranch::PrintDataTo(StringStream* stream) { 207 void LBranch::PrintDataTo(StringStream* stream) {
203 stream->Add("B%d | B%d on ", true_block_id(), false_block_id()); 208 stream->Add("B%d | B%d on ", true_block_id(), false_block_id());
204 value()->PrintTo(stream); 209 value()->PrintTo(stream);
205 } 210 }
206 211
(...skipping 2320 matching lines...) Expand 10 before | Expand all | Expand 10 after
2527 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2532 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2528 LOperand* object = UseRegister(instr->object()); 2533 LOperand* object = UseRegister(instr->object());
2529 LOperand* index = UseTempRegister(instr->index()); 2534 LOperand* index = UseTempRegister(instr->index());
2530 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2535 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2531 } 2536 }
2532 2537
2533 2538
2534 } } // namespace v8::internal 2539 } } // namespace v8::internal
2535 2540
2536 #endif // V8_TARGET_ARCH_X64 2541 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/ia32/lithium-ia32.cc ('K') | « src/x64/lithium-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698