Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1437053002: Flip "Linux x64", linux_chromium_archive_rel_ng bots to MB. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip "Linux x64", linux_chromium_archive_rel_ng bots to MB. This is a re-land of #358743, with the change that we'll still build w/ GYP for the moment. Once we're sure that the MB part is fine, we can flip to GN in another CL. R=petermayo@chromium.org, phajdan.jr@chromium.org BUG=545480, 531296 Committed: https://crrev.com/047d631aa0d007a29782b793b9054d290e42c678 Cr-Commit-Position: refs/heads/master@{#359882}

Patch Set 1 : original patch #

Patch Set 2 : revert to GYP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M testing/buildbot/chromium.json View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Dirk Pranke
5 years, 1 month ago (2015-11-12 01:47:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437053002/20001
5 years, 1 month ago (2015-11-12 01:50:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 03:31:12 UTC) #6
Paweł Hajdan Jr.
I'd prefer to wait until the conversion of that bot to recipes can be considered ...
5 years, 1 month ago (2015-11-12 15:13:18 UTC) #7
Dirk Pranke
On 2015/11/12 15:13:18, Paweł Hajdan Jr. wrote: > I'd prefer to wait until the conversion ...
5 years, 1 month ago (2015-11-12 17:17:49 UTC) #8
Dirk Pranke
Please take another look; we've had several build failures on the official builders in the ...
5 years, 1 month ago (2015-11-16 00:28:06 UTC) #9
Paweł Hajdan Jr.
LGTM My changes to sizes.py have landed and work. :)
5 years, 1 month ago (2015-11-16 17:26:49 UTC) #10
Dirk Pranke
excellent.
5 years, 1 month ago (2015-11-16 17:29:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437053002/20001
5 years, 1 month ago (2015-11-16 17:29:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-16 19:00:57 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 19:01:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/047d631aa0d007a29782b793b9054d290e42c678
Cr-Commit-Position: refs/heads/master@{#359882}

Powered by Google App Engine
This is Rietveld 408576698