Fix harmony sloppy block scoping dynamic redeclaration check

src/runtime/runtime-scopes.cc

Index: src/runtime/runtime-scopes.cc
diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc
index ecbe5cd17d953a7a13c667674425704100ce2e68..49320b2a42be7f140c5e6647a6e6fbf1764a2e5b 100644
--- a/src/runtime/runtime-scopes.cc
+++ b/src/runtime/runtime-scopes.cc
@@ -231,7 +231,8 @@ Object* DeclareLookupSlot(Isolate* isolate, Handle<String> name,
                         &binding_flags);
     if (attributes != ABSENT &&
         (binding_flags == MUTABLE_CHECK_INITIALIZED ||
-         binding_flags == IMMUTABLE_CHECK_INITIALIZED)) {
+         binding_flags == IMMUTABLE_CHECK_INITIALIZED ||

[adamk, 2015/11/12 23:22:27]

This is for CONST_LEGACY, I wonder if it even belongs here...

[adamk, 2015/11/13 07:06:01]

Any thoughts on this? The comment above claims this is for checking lexical
conflicts, but IMMUTABLE_CHECK_INITIALIZED is checking a non-lexical binding.

+         binding_flags == IMMUTABLE_CHECK_INITIALIZED_HARMONY)) {
       return ThrowRedeclarationError(isolate, name);
     }
     attr = static_cast<PropertyAttributes>(attr & ~EVAL_DECLARED);