Chromium Code Reviews

Unified Diff: third_party/WebKit/Source/web/WebSettingsImpl.h

Issue 1437003005: Oilpan: account for DevToolsEmulator reference from WebSettingsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebSettingsImpl.h
diff --git a/third_party/WebKit/Source/web/WebSettingsImpl.h b/third_party/WebKit/Source/web/WebSettingsImpl.h
index 4524b3dbfdc7f5e194c277a58c354171dd6e10db..6835ec3697a613298d20af32d2d083c8e796ddb0 100644
--- a/third_party/WebKit/Source/web/WebSettingsImpl.h
+++ b/third_party/WebKit/Source/web/WebSettingsImpl.h
@@ -31,6 +31,7 @@
#ifndef WebSettingsImpl_h
#define WebSettingsImpl_h
+#include "platform/heap/Handle.h"
#include "public/web/WebSettings.h"
namespace blink {
@@ -207,7 +208,7 @@ public:
private:
Settings* m_settings;
- DevToolsEmulator* m_devToolsEmulator;
+ RawPtrWillBeUntracedMember<DevToolsEmulator> m_devToolsEmulator;
haraken 2015/11/13 11:47:51 As commented in another CL, I think our plan is to
sof 2015/11/13 13:31:48 See the description for why I consider that is exc
haraken 2015/11/13 13:39:41 LGTM. It's still not quite clear to me when we sh
bool m_showFPSCounter;
bool m_showPaintRects;
bool m_renderVSyncNotificationEnabled;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine