Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
14370003:
Use device Robot Account to access Cloud Print. (Closed)
|
Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS) Modified:
7 years, 8 months ago CC:
chromium-reviews, arv+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionUse device Robot Account to access Cloud Print.
- Search requests uses both: current cookies and OAuth2 token for device Robot Account.
- User cookies or OAuth2 used in search for operation with a printer (print, get capabilities etc.)
- Put printer accessible for Robot Account to local destination.
BUG=179229
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195371
Patch Set 1 #
Total comments: 6
Patch Set 2 : #
Total comments: 13
Patch Set 3 : #
Total comments: 39
Patch Set 4 : #
Total comments: 5
Patch Set 5 : #
Messages
Total messages: 10 (0 generated)
lgtm https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:13: * @param {!print_preview.NativeLayer} nativeLayer Native layer. Can you add a short desc about what it's used for. https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:34: * parameter in every request. Some of these words can fit on the line above. https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:35: * @type {Dictionary} You can use {Object.<XXX: , YYY: >} https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:137: addEventListeners_: function() { Please move private methods after public methods. https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:149: onAccessTokenReady_: function(event) { Please move private methods after public methods. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:38: this.xsrfTokens_ = {}; Get rid of this cache. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:45: this.pendingRequests_ = {}; this.deviceRequestQueue_ https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:137: addEventListeners_: function() { Move after public methods. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:152: for (var i in requests) { requests.forEach(function(request) {}); https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:178: var cloud_origins = [ Move this into a static constant. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:184: for (var type in cloud_origins) { cloud_origins.forEach(function(type) { }); https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:187: this.sendRequest_('GET', 'search', params, origin, var cpRequest = this.buildRequest_('GET', 'search', params); this.sendOrQueueRequest_(cpRequest, callback, origin); sendOrQueueRequest_: function(cpReq, callback, origin) { } sendRequest_: function() { } https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:243: updatePrinterTosAcceptance: function(printerId, origin, isAccepted) { 1. Change order so that origin is at the end. 2. Update callers of this method to pass in origin. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:335: sendRequest_: function(method, action, params, origin, callback) { Change this method to buildRequest_(...); with output of {body, xhr}. Return {xhr: xhr, body: body}.
https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/1/chrome/browser/resources/prin... chrome/browser/resources/print_preview/cloud_print_interface.js:13: * @param {!print_preview.NativeLayer} nativeLayer Native layer. On 2013/04/19 01:58:21, Toscano wrote: > Can you add a short desc about what it's used for. Done. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:38: this.xsrfTokens_ = {}; On 2013/04/19 01:58:21, Toscano wrote: > Get rid of this cache. Done. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:45: this.pendingRequests_ = {}; On 2013/04/19 01:58:21, Toscano wrote: > this.deviceRequestQueue_ Done. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:137: addEventListeners_: function() { On 2013/04/19 01:58:21, Toscano wrote: > Move after public methods. Done. https://codereview.chromium.org/14370003/diff/2001/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:152: for (var i in requests) { On 2013/04/19 01:58:21, Toscano wrote: > requests.forEach(function(request) {}); Done.
https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:42: * @type {!Array<objects>} The type looks like: {!Array.<Object>} https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:127: * @type {!Array<!print_preview.Destination.Origin>} Missing the "." between "Array" and "<!...": {!Array.<!print...>} https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:237: this.onUpdateTosAcceptanceDone_.bind(this)); Why did you change the name of the callback? Now it doesn't match the name of this function. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:256: onAccessTokenReady_: function(event) { private handlers should come after all other private methods. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:259: assert(request.origin == print_preview.Destination.Origin.DEVICE); Can you add a TODO to remove this assert once we support multiple Origin types? https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:260: if (request.origin != event.authType) Please enclose "if" body with {} https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:268: request.callback(401, { Should be 403. With a string as the second parameter. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:338: * @private Where is the @return statement? https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:341: var url = this.baseUrl_ + '/' + action + '?xsrf='; You add "xsrf=" to the url, but you only provide a value in COOKIES case. This might cause an invalid XSRF token error on the server. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:382: return new ClourPrintRequest(xhr, body, origin); Cloud*PrintRequest. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:386: * Sends a request to the Google Cloud Print API. Or queue if it needs to This is one sentence. No need for a period before "Or". https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:393: sendOrQueueRequest_: function(request, callback) { It actually looks like it makes more sense to include the callback parameter in the buildRequest_ function. Let's move it there. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:394: request.callback = callback; The CloudPrintRequest does not have a callback field, can you add it? https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:403: sendRequest_: function(request) { Please add jsdoc for this method. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:441: request.callback(request.xhr.status, result, request.origin); Let's just add a result field to CloudPrintRequest and pass result to the callback because we might add more fields later: request.result = result; request.callback(request); https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:553: * Data structure that holds data for delayed Cloud Print requests. delayed: not all of them are delayed. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:559: function ClourPrintRequest(xhr, body, origin) { Cloud*PrintRequest https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:559: function ClourPrintRequest(xhr, body, origin) { Please add callback parameter. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:577: }; Please add "callback" and "result" fields.
https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:42: * @type {!Array<objects>} On 2013/04/19 17:04:33, Toscano wrote: > The type looks like: {!Array.<Object>} Actually i have type so * @type {!Array<!ClourPrintRequest>} https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:127: * @type {!Array<!print_preview.Destination.Origin>} On 2013/04/19 17:04:33, Toscano wrote: > Missing the "." between "Array" and "<!...": > > {!Array.<!print...>} Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:237: this.onUpdateTosAcceptanceDone_.bind(this)); On 2013/04/19 17:04:33, Toscano wrote: > Why did you change the name of the callback? Now it doesn't match the name of > this function. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:256: onAccessTokenReady_: function(event) { On 2013/04/19 17:04:33, Toscano wrote: > private handlers should come after all other private methods. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:259: assert(request.origin == print_preview.Destination.Origin.DEVICE); On 2013/04/19 17:04:33, Toscano wrote: > Can you add a TODO to remove this assert once we support multiple Origin types? Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:260: if (request.origin != event.authType) On 2013/04/19 17:04:33, Toscano wrote: > Please enclose "if" body with {} Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:268: request.callback(401, { On 2013/04/19 17:04:33, Toscano wrote: > Should be 403. 403 cause sign in promo >With a string as the second parameter. actually it's goes always to createErrorEvent_ And jsdoc there: {@code null} if status was not 200. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:338: * @private On 2013/04/19 17:04:33, Toscano wrote: > Where is the @return statement? Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:341: var url = this.baseUrl_ + '/' + action + '?xsrf='; that's how search request worked before, the first always was with ?xsrf=&... On 2013/04/19 17:04:33, Toscano wrote: > You add "xsrf=" to the url, but you only provide a value in COOKIES case. This > might cause an invalid XSRF token error on the server. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:382: return new ClourPrintRequest(xhr, body, origin); On 2013/04/19 17:04:33, Toscano wrote: > Cloud*PrintRequest. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:386: * Sends a request to the Google Cloud Print API. Or queue if it needs to On 2013/04/19 17:04:33, Toscano wrote: > This is one sentence. No need for a period before "Or". Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:393: sendOrQueueRequest_: function(request, callback) { On 2013/04/19 17:04:33, Toscano wrote: > It actually looks like it makes more sense to include the callback parameter in > the buildRequest_ function. Let's move it there. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:394: request.callback = callback; On 2013/04/19 17:04:33, Toscano wrote: > The CloudPrintRequest does not have a callback field, can you add it? Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:403: sendRequest_: function(request) { On 2013/04/19 17:04:33, Toscano wrote: > Please add jsdoc for this method. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:441: request.callback(request.xhr.status, result, request.origin); On 2013/04/19 17:04:33, Toscano wrote: > Let's just add a result field to CloudPrintRequest and pass result to the > callback because we might add more fields later: > > request.result = result; > request.callback(request); Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:553: * Data structure that holds data for delayed Cloud Print requests. On 2013/04/19 17:04:33, Toscano wrote: > delayed: not all of them are delayed. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:559: function ClourPrintRequest(xhr, body, origin) { On 2013/04/19 17:04:33, Toscano wrote: > Cloud*PrintRequest Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:559: function ClourPrintRequest(xhr, body, origin) { On 2013/04/19 17:04:33, Toscano wrote: > Please add callback parameter. Done. https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:577: }; On 2013/04/19 17:04:33, Toscano wrote: > Please add "callback" and "result" fields. Done.
lgtm, make sure to get one from Robert as well. On 2013/04/19 22:14:29, Vitaly Buka wrote: > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > File chrome/browser/resources/print_preview/cloud_print_interface.js (right): > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:42: * @type > {!Array<objects>} > On 2013/04/19 17:04:33, Toscano wrote: > > The type looks like: {!Array.<Object>} > > Actually i have type so * @type {!Array<!ClourPrintRequest>} > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:127: * @type > {!Array<!print_preview.Destination.Origin>} > On 2013/04/19 17:04:33, Toscano wrote: > > Missing the "." between "Array" and "<!...": > > > > {!Array.<!print...>} > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:237: > this.onUpdateTosAcceptanceDone_.bind(this)); > On 2013/04/19 17:04:33, Toscano wrote: > > Why did you change the name of the callback? Now it doesn't match the name of > > this function. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:256: > onAccessTokenReady_: function(event) { > On 2013/04/19 17:04:33, Toscano wrote: > > private handlers should come after all other private methods. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:259: > assert(request.origin == print_preview.Destination.Origin.DEVICE); > On 2013/04/19 17:04:33, Toscano wrote: > > Can you add a TODO to remove this assert once we support multiple Origin > types? > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:260: if > (request.origin != event.authType) > On 2013/04/19 17:04:33, Toscano wrote: > > Please enclose "if" body with {} > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:268: > request.callback(401, { > On 2013/04/19 17:04:33, Toscano wrote: > > Should be 403. > 403 cause sign in promo > > >With a string as the second parameter. > actually it's goes always to createErrorEvent_ > > And jsdoc there: > {@code null} if status was not 200. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:338: * @private > On 2013/04/19 17:04:33, Toscano wrote: > > Where is the @return statement? > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:341: var url = > this.baseUrl_ + '/' + action + '?xsrf='; > that's how search request worked before, the first always was with ?xsrf=&... > > On 2013/04/19 17:04:33, Toscano wrote: > > You add "xsrf=" to the url, but you only provide a value in COOKIES case. This > > might cause an invalid XSRF token error on the server. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:382: return new > ClourPrintRequest(xhr, body, origin); > On 2013/04/19 17:04:33, Toscano wrote: > > Cloud*PrintRequest. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:386: * Sends a > request to the Google Cloud Print API. Or queue if it needs to > On 2013/04/19 17:04:33, Toscano wrote: > > This is one sentence. No need for a period before "Or". > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:393: > sendOrQueueRequest_: function(request, callback) { > On 2013/04/19 17:04:33, Toscano wrote: > > It actually looks like it makes more sense to include the callback parameter > in > > the buildRequest_ function. Let's move it there. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:394: > request.callback = callback; > On 2013/04/19 17:04:33, Toscano wrote: > > The CloudPrintRequest does not have a callback field, can you add it? > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:403: > sendRequest_: function(request) { > On 2013/04/19 17:04:33, Toscano wrote: > > Please add jsdoc for this method. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:441: > request.callback(request.xhr.status, result, request.origin); > On 2013/04/19 17:04:33, Toscano wrote: > > Let's just add a result field to CloudPrintRequest and pass result to the > > callback because we might add more fields later: > > > > request.result = result; > > request.callback(request); > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:553: * Data > structure that holds data for delayed Cloud Print requests. > On 2013/04/19 17:04:33, Toscano wrote: > > delayed: not all of them are delayed. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:559: function > ClourPrintRequest(xhr, body, origin) { > On 2013/04/19 17:04:33, Toscano wrote: > > Cloud*PrintRequest > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:559: function > ClourPrintRequest(xhr, body, origin) { > On 2013/04/19 17:04:33, Toscano wrote: > > Please add callback parameter. > > Done. > > https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... > chrome/browser/resources/print_preview/cloud_print_interface.js:577: }; > On 2013/04/19 17:04:33, Toscano wrote: > > Please add "callback" and "result" fields. > > Done.
lgtm https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/2004/chrome/browser/resources/p... chrome/browser/resources/print_preview/cloud_print_interface.js:341: var url = this.baseUrl_ + '/' + action + '?xsrf='; Ok, not a big deal. As long as it works. On 2013/04/19 22:14:29, Vitaly Buka wrote: > that's how search request worked before, the first always was with ?xsrf=&... > > On 2013/04/19 17:04:33, Toscano wrote: > > You add "xsrf=" to the url, but you only provide a value in COOKIES case. This > > might cause an invalid XSRF token error on the server. > https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... chrome/browser/resources/print_preview/cloud_print_interface.js:381: /** Messed up indentation here. https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... chrome/browser/resources/print_preview/cloud_print_interface.js:383: * @param {!CloudPrintRequest} request Request to send or queue. The request is never queued in this method.
https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... File chrome/browser/resources/print_preview/cloud_print_interface.js (right): https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... chrome/browser/resources/print_preview/cloud_print_interface.js:381: /** On 2013/04/19 22:32:33, Toscano wrote: > Messed up indentation here. Done. https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... chrome/browser/resources/print_preview/cloud_print_interface.js:383: * @param {!CloudPrintRequest} request Request to send or queue. On 2013/04/19 22:32:33, Toscano wrote: > The request is never queued in this method. Done. https://codereview.chromium.org/14370003/diff/22001/chrome/browser/resources/... chrome/browser/resources/print_preview/cloud_print_interface.js:383: * @param {!CloudPrintRequest} request Request to send or queue. On 2013/04/19 22:32:33, Toscano wrote: > The request is never queued in this method. Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14370003/33002
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14370003/33002
Message was sent while issue was closed.
Change committed as 195371 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
