Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1436943007: [Android] add missing comma to multidex gyp parameter configuration. (Closed)

Created:
5 years, 1 month ago by jbudorick
Modified:
5 years, 1 month ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] add missing comma to multidex gyp parameter configuration. Missed a comma in https://codereview.chromium.org/1408163009/ BUG=272970 TBR=yfriedman@chromium.org Committed: https://crrev.com/8c6d60262a2f0361de2921107c5191d9c9775da4 Cr-Commit-Position: refs/heads/master@{#359483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/java_apk.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
jbudorick
shame, shame, shame
5 years, 1 month ago (2015-11-13 01:47:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436943007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436943007/1
5 years, 1 month ago (2015-11-13 01:49:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/157257) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-13 01:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436943007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436943007/1
5 years, 1 month ago (2015-11-13 01:58:41 UTC) #7
Yaron
lgtm
5 years, 1 month ago (2015-11-13 02:28:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/140128)
5 years, 1 month ago (2015-11-13 02:35:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436943007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436943007/1
5 years, 1 month ago (2015-11-13 02:37:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 03:04:59 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 03:06:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c6d60262a2f0361de2921107c5191d9c9775da4
Cr-Commit-Position: refs/heads/master@{#359483}

Powered by Google App Engine
This is Rietveld 408576698